Modify rule S5146: Fix invalid Python sample #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't get Sonarcloud to trigger this issue using the provided noncompliant code example. I think the code examples as written end up being circular because the local function 'redirect()' will call itself rather than the imported 'redirect()' function of the same name. The fix is to change the local function name to be redirecting(). I changed the API endpoint name as well so that it matched.
If you keep the Flask call in, it triggers a different hotspot instead of this rule. Removing it seems to mean that this example triggers this rule.
Undo my removal of 'Flask()' calls. This will cause a hotspot to be raised but I don't know enough to fix that properly so will have to leave it for now. I'll leave this PR solving the circular call issue and raise a dogfood post on the compliant code causing a hotspot to appear.
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
hendrik-buchwald-sonarsource
approved these changes
Jun 29, 2023
hendrik-buchwald-sonarsource
changed the title
guillaume-dequenne-sonarsource
pushed a commit
that referenced
this pull request
Jul 3, 2023
I couldn't get Sonarcloud to trigger this issue using the provided noncompliant code example. I think the code examples as written end up being circular because the local function 'redirect()' will call itself rather than the imported 'redirect()' function of the same name. The fix is to change the local function name to be redirecting(). I changed the API endpoint name as well so that it matched. Once I had made this change, the noncompliant code example did lead to Sonarcloud spotting the issue. ## Review A dedicated reviewer checked the rule description successfully for: - [x] logical errors and incorrect information - [x] information gaps and missing content - [x] text style and tone - [x] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get Sonarcloud to trigger this issue using the provided noncompliant code example.
I think the code examples as written end up being circular because the local function 'redirect()' will call itself rather than the imported 'redirect()' function of the same name. The fix is to change the local function name to be redirecting(). I changed the API endpoint name as well so that it matched. Once I had made this change, the noncompliant code example did lead to Sonarcloud spotting the issue.
Review
A dedicated reviewer checked the rule description successfully for: