Modify rule S6388: Add language AzureResourceManager (Bicep) #1925
Conversation
rudy-regazzoni-sonarsource
force-pushed
the
rule/S6388-add-azureresourcemanager-bicep
branch
from
6e4724a to
da460a3
Compare
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
jonas-wielage-sonarsource
force-pushed
the
rule/S6388-add-azureresourcemanager-bicep
branch
from
da460a3 to
1cf01b4
Compare
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
rudy-regazzoni-sonarsource
deleted the
rule/S6388-add-azureresourcemanager-bicep
branch
There was a problem hiding this comment.
Hi @rudy-regazzoni-sonarsource
This PR introduced some regressions: https://cirrus-ci.com/task/6481755893399552?logs=asciidoc_tests#L93-L101
[S6388/azureresourcemanager] diff-id=113 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_virtualMachines.compliant.adoc:118
[S6388/azureresourcemanager] diff-id=116 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_virtualMachines.compliant.adoc:269
[S6388/azureresourcemanager] diff-id=213 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_virtualMachineScaleSets.compliant.adoc:128
[S6388/azureresourcemanager] diff-id=215 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_virtualMachineScaleSets.compliant.adoc:234
[S6388/azureresourcemanager] diff-id=311 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_disks.compliant.adoc:26
[S6388/azureresourcemanager] diff-id=312 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_disks.compliant.adoc:68
[S6388/azureresourcemanager] diff-id=313 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_disks.compliant.adoc:110
[S6388/azureresourcemanager] diff-id=411 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_snapshots.compliant.adoc:26
[S6388/azureresourcemanager] diff-id=413 has zero noncompliant example: /tmp/cirrus-ci-build/rules/S6388/azureresourcemanager/examples/Microsoft.Compute_snapshots.compliant.adoc:114
Could you have a look and fix them? This is blocking #2883 which should make those regressions obvious.
Thanks.
| @@ -80,6 +111,28 @@ Enabled encryption for managed disk through security profile: | |||
| } | |||
| ---- | |||
|
|
|||
| [source,bicep,diff-id=113,diff-type=compliant] | |||
There was a problem hiding this comment.
This one, and other snippets, have no noncompliant examples.
|
Hello @marco-antognini-sonarsource ! |
…mpliant equivalent (#3070) ## Review A dedicated reviewer checked the rule description successfully for: - [ ] logical errors and incorrect information - [ ] information gaps and missing content - [ ] text style and tone - [ ] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) [Related issue](#1925 (review))
Specification ticket: https://sonarsource.atlassian.net/browse/SONARIAC-759