Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S6387: Add language AzureResourceManager (Bicep) #1907

Merged
merged 9 commits into from
Sep 13, 2023
Merged

Modify rule S6387: Add language AzureResourceManager (Bicep) #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1dbcf77
Add ARM example
egon-okerman-sonarsource May 9, 2023
5aa968c
Add "Sensitive" lines
egon-okerman-sonarsource May 10, 2023
67dbde1
Fix mistakes in code samples
egon-okerman-sonarsource May 10, 2023
a2b1d9f
Replace unclear line in Bicep compliant example
egon-okerman-sonarsource May 10, 2023
1e86e2f
Update highlighting
egon-okerman-sonarsource May 10, 2023
35afba6
Correctly link to highlighting page
egon-okerman-sonarsource May 10, 2023
18f43ca
Update code examples to be simpler
egon-okerman-sonarsource May 15, 2023
9a0aec5
Remove Bicep examples
egon-okerman-sonarsource May 15, 2023
395e2fb
Revert "Remove Bicep examples"
egon-okerman-sonarsource May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions rules/S6387/azureresourcemanager/highlighting.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
=== Highlighting
==== JSON

Highlight the relevant `$schema` property

==== Bicep

Highlight the relevant `targetScope` property
30 changes: 20 additions & 10 deletions rules/S6387/azureresourcemanager/rule.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ include::../recommended.adoc[]

== Sensitive Code Example

[source,bicep,diff-id=1,diff-type=noncompliant]
----
targetScope = 'subscription' // Sensitive

resource roleAssignment 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
name: guid(subscription().id, 'exampleRoleAssignment')
}
----

[source,json,diff-id=2,diff-type=noncompliant]
----
{
Expand All @@ -23,7 +32,16 @@ include::../recommended.adoc[]

== Compliant Solution

[source,json,diff-id=2,diff-type=compliant]
[source,bicep,diff-id=1,diff-type=compliant]
----
targetScope = 'resourceGroup'

resource roleAssignment 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
name: guid(resourceGroup().id, 'exampleRoleAssignment')
}
----

[source,json,diff-id=2,diff-type=noncompliant]
egon-okerman-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
----
{
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
Expand All @@ -49,14 +67,6 @@ ifdef::env-github,rspecator-view[]

include::../message.adoc[]

=== Highlighting
==== JSON

Highlight the relevant `$schema` property

==== Bicep

Highlight the relevant `targetScope` property

include::highlighting.adoc[]

endif::env-github,rspecator-view[]