Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S6387: Add language AzureResourceManager (JSON) #1842

Merged
merged 9 commits into from
May 17, 2023
Merged

Modify rule S6387: Add language AzureResourceManager (JSON) #1842

merged 9 commits into from
May 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 9, 2023 •
edited by egon-okerman-sonarsource
Loading

@github-actions github-actions bot added the iac label May 9, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource marked this pull request as ready for review May 10, 2023 14:48
rudy-regazzoni-sonarsource
rudy-regazzoni-sonarsource requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good. The example seems too complex to me unless I misunderstood the rule.
I would prefer them to be reduced to minimal examples to best showcase the key-elements and what are their sensitive/compliant values.
Let me know if you want to discuss it.

rules/S6387/azureresourcemanager/rule.adoc Outdated Show resolved Hide resolved
rules/S6387/azureresourcemanager/rule.adoc Outdated Show resolved Hide resolved
rules/S6387/azureresourcemanager/rule.adoc Outdated Show resolved Hide resolved
rules/S6387/azureresourcemanager/rule.adoc Outdated Show resolved Hide resolved
rules/S6387/azureresourcemanager/rule.adoc Outdated Show resolved Hide resolved
rules/S6387/azureresourcemanager/rule.adoc Outdated Show resolved Hide resolved
@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Create rule S6387 Modify rule S6387: Add language AzureResourceManager (JSON) May 15, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource mentioned this pull request May 15, 2023
Merged
rudy-regazzoni-sonarsource
rudy-regazzoni-sonarsource approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I let you check the issue with link validation before merging.

@egon-okerman-sonarsource egon-okerman-sonarsource force-pushed the rule/S6387-add-azureresourcemanager branch from 35437d7 to 4f0c165 Compare May 17, 2023 10:30
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@egon-okerman-sonarsource egon-okerman-sonarsource merged commit a4ba829 into master May 17, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource deleted the rule/S6387-add-azureresourcemanager branch May 17, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egon-okerman-sonarsource egon-okerman-sonarsource egon-okerman-sonarsource left review comments

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource approved these changes

Assignees

@egon-okerman-sonarsource egon-okerman-sonarsource

Labels
iac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudy-regazzoni-sonarsource @egon-okerman-sonarsource