Modify rule S5122: Update code snippets about user-controlled origin (#…

…3963)
SonarSource · Jun 5, 2024 · a5c028a · a5c028a
1 parent 70bdb31
commit a5c028a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/rules/S5122/javascript/rule.adoc b/rules/S5122/javascript/rule.adoc
@@ -40,7 +40,7 @@ User-controlled origin:
 [source,javascript]
 ----
 function (req, res) {
-  const origin = req.header('Origin');
+  const origin = req.headers.origin;
   res.setHeader('Access-Control-Allow-Origin', origin); // Sensitive
 };
 ----
@@ -78,9 +78,9 @@ User-controlled origin validated with an allow-list:
 [source,javascript]
 ----
 function (req, res) {
-  const origin = req.header('Origin');
+  const origin = req.headers.origin;
 
-  if (trustedOrigins.indexOf(origin) >= 0) {
+  if (origin === 'trustedwebsite.com') {
     res.setHeader('Access-Control-Allow-Origin', origin);
   }
 };