Merge branch 'master' into rule/S2253-add-cfamily

SonarSource · Dec 2, 2024 · 8da79ba · 8da79ba
2 parents 53846e9 + b2b1cb9
commit 8da79ba
Show file tree

Hide file tree

Showing 288 changed files with 3,617 additions and 1,720 deletions.
diff --git a/.cirrus.star b/.cirrus.star
@@ -1,4 +1,4 @@
-load("github.com/SonarSource/cirrus-modules@v2", "load_features")
+load("github.com/SonarSource/cirrus-modules@v3", "load_features")
 
 def main(ctx):
     return load_features(ctx)
diff --git a/LICENSE b/LICENSE
diff --git a/README.adoc b/README.adoc
@@ -8,6 +8,8 @@ This repository contains the specification of every static-analysis rule availab
 
 It also contains rules which have been dropped and rules which will one day be implemented.
 
+The content of this repository is covered by the link:LICENSE[SONAR Source-Available License v1.0].
+
 == Rules directory structure
 
 * https://github.com/SonarSource/rspec/tree/master/rules[rules] directory: contains every specified rule.

diff --git a/frontend/public/covered_rules.json b/frontend/public/covered_rules.json
diff --git a/rspec-tools/rspec_tools/checklinks.py b/rspec-tools/rspec_tools/checklinks.py
@@ -1,12 +1,11 @@
-import os,io
-import re
-import requests
+import datetime
 import json
+import pathlib
 import random
-import datetime
+import socket
+
+import requests
 from bs4 import BeautifulSoup
-from socket import timeout
-import pathlib
 
 TOLERABLE_LINK_DOWNTIME = datetime.timedelta(days=7)
 LINK_PROBES_HISTORY_FILE = './link_probes.history'
@@ -73,7 +72,7 @@ def live_url(url: str, timeout=5):
     req = requests.Request('GET', url, headers = {'sec-ch-ua': '" Not A;Brand";v="99", "Chromium";v="90"',
                                                   'sec-ch-ua-mobile': '?0',
                                                   'Upgrade-Insecure-Requests': '1',
-                                                  'User-Agent': 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36',
+                                                  'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 GLS/100.10.9939.100',
                                                   'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9',
                                                   'Sec-Fetch-Site':'none',
                                                   'Sec-Fetch-Mode':'navigate',
@@ -102,13 +101,13 @@ def live_url(url: str, timeout=5):
     print(f"ERROR: Too many redirects: {rr}")
     return False
   except requests.Timeout as t:
-    print(f"ERROR: timeout ", t)
+    print(f"ERROR: Request timeout {t}")
     return False
-  except timeout as t:
-    print(f"ERROR: timeout ", t)
+  except socket.timeout as t:
+    print(f"ERROR: Socket timeout {t}")
     return False
   except Exception as e:
-    print(f"ERROR: ", e)
+    print(f"ERROR: {e}")
     return False
 
 def findurl_in_html(filename,urls):

diff --git a/rspec-tools/rspec_tools/coverage.py b/rspec-tools/rspec_tools/coverage.py
@@ -17,7 +17,7 @@
   'sonar-css',
   'sonar-dart',
   'sonar-dataflow-bug-detection',
-  'sonar-dotnet',
+  'sonar-dotnet-enterprise',
   'sonar-flex',
   'sonar-go',
   'sonar-html',

diff --git a/rules/S100/flex/metadata.json b/rules/S100/flex/metadata.json
@@ -1,5 +1,2 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+}
diff --git a/rules/S1005/flex/metadata.json b/rules/S1005/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S101/flex/metadata.json b/rules/S101/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S103/flex/metadata.json b/rules/S103/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1066/flex/metadata.json b/rules/S1066/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1068/flex/metadata.json b/rules/S1068/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S107/flex/metadata.json b/rules/S107/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S108/flex/metadata.json b/rules/S108/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1116/flex/metadata.json b/rules/S1116/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1117/flex/metadata.json b/rules/S1117/flex/metadata.json
@@ -1,6 +1,3 @@
 {
-  "title": "Local variables should not shadow class fields",
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+  "title": "Local variables should not shadow class fields"
+}
diff --git a/rules/S1125/flex/metadata.json b/rules/S1125/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1135/flex/metadata.json b/rules/S1135/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1142/flex/metadata.json b/rules/S1142/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1144/flex/metadata.json b/rules/S1144/flex/metadata.json
@@ -1,6 +1,3 @@
 {
-  "title": "Unused \"private\" functions should be removed",
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+  "title": "Unused \"private\" functions should be removed"
+}
diff --git a/rules/S1145/flex/metadata.json b/rules/S1145/flex/metadata.json
@@ -1,5 +1,2 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+}
diff --git a/rules/S115/flex/metadata.json b/rules/S115/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S115/java/rule.adoc b/rules/S115/java/rule.adoc
@@ -57,6 +57,23 @@ public enum MyEnum {
 }
 ----
 
+=== Exceptions
+
+The rule applies to fields of primitive types (for example, ``float``), boxed primitives (``Float``), and Strings.
+We do not apply it to other types, which can be mutated, or have methods with side effects.
+
+[source,java]
+----
+public static final Logger log = getLogger(MyClass.class);
+public static final List<Integer> myList = new ArrayList<>();
+
+// call with side-effects
+log.info("message")
+
+// mutating an object
+myList.add(28);
+----
+
 == Resources
 
 === External coding guidelines

diff --git a/rules/S1151/flex/metadata.json b/rules/S1151/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S116/flex/metadata.json b/rules/S116/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S117/flex/metadata.json b/rules/S117/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1170/flex/metadata.json b/rules/S1170/flex/metadata.json
@@ -1,6 +1,3 @@
 {
-  "title": "Public constants and fields initialized at declaration should be \"const static\" rather than merely \"const\"",
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+  "title": "Public constants and fields initialized at declaration should be \"const static\" rather than merely \"const\""
+}
diff --git a/rules/S1172/flex/metadata.json b/rules/S1172/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1176/flex/metadata.json b/rules/S1176/flex/metadata.json
@@ -1,6 +1,3 @@
 {
-  "title": "Public classes, methods, properties and metadata should be documented with ASDoc",
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+  "title": "Public classes, methods, properties and metadata should be documented with ASDoc"
+}
diff --git a/rules/S1185/flex/metadata.json b/rules/S1185/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1186/flex/metadata.json b/rules/S1186/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S120/flex/metadata.json b/rules/S120/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S122/flex/metadata.json b/rules/S122/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S1224/flex/metadata.json b/rules/S1224/flex/metadata.json
@@ -1,6 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": [],
-  "quickfix": "unknown"
+
 }
diff --git a/rules/S124/flex/metadata.json b/rules/S124/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S125/flex/metadata.json b/rules/S125/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S127/flex/metadata.json b/rules/S127/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S128/flex/metadata.json b/rules/S128/flex/metadata.json
@@ -1,5 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": []
-}
+
+}
diff --git a/rules/S129/flex/metadata.json b/rules/S129/flex/metadata.json
@@ -1,10 +1,3 @@
 {
-  "tags": [],
-  "status": "deprecated",
-  "defaultQualityProfiles": [],
-  "quickfix": "unknown",
-  "remediation": {
-    "func": "Constant\/Issue",
-    "constantCost": "10min"
-  }
+
 }
diff --git a/rules/S1291/javascript/metadata.json b/rules/S1291/javascript/metadata.json
@@ -0,0 +1,2 @@
+{
+}