Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS-542 - Implement the deduplication of issues raised from both SonarJS and ESLint #5089

Merged
merged 7 commits into from
Feb 5, 2025
Merged

JS-542 - Implement the deduplication of issues raised from both SonarJS and ESLint #5089

merged 7 commits into from
Feb 5, 2025

Conversation

ericmorand-sonarsource
Copy link
Contributor

@ericmorand-sonarsource ericmorand-sonarsource commented Jan 30, 2025 •
edited
Loading

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title WIP JS-543 WIP Jan 30, 2025
@ericmorand-sonarsource ericmorand-sonarsource force-pushed the JS-542 branch 25 times, most recently from 8b1c375 to 22fb440 Compare February 3, 2025 12:21
@ericmorand-sonarsource ericmorand-sonarsource changed the title JS-543 WIP JS-542 WIP Feb 3, 2025
@ericmorand-sonarsource ericmorand-sonarsource force-pushed the JS-542 branch 3 times, most recently from 2d245e9 to 714c329 Compare February 3, 2025 15:56
@ericmorand-sonarsource ericmorand-sonarsource force-pushed the JS-542 branch 5 times, most recently from f69fae4 to 595ca37 Compare February 4, 2025 09:11
WIP
b64c2f2 
Basically, executing the tests using the CI platform.
@ericmorand-sonarsource ericmorand-sonarsource changed the title JS-542 WIP JS-542 - Implement the deduplication of issues raised from both SonarJS and ESLint Feb 5, 2025
@ericmorand-sonarsource ericmorand-sonarsource marked this pull request as ready for review February 5, 2025 12:21
@ericmorand-sonarsource ericmorand-sonarsource requested a review from a team February 5, 2025 13:42
vdiez
vdiez approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a console.log you forgot

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/EslintReportTest.java Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Feb 5, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
3 Accepted issues

Measures
0 Security Hotspots
95.8% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube

@ericmorand-sonarsource ericmorand-sonarsource merged commit 1dae58f into master Feb 5, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdiez vdiez vdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericmorand-sonarsource @vdiez