Support correct repository (description) for CustomCxxRulesDefinition #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayed in the report. Corrected CxxSquidSensor's saveViolations function to allow creation of new issues with a source other than "cxx", enabling reporting of detection results based on CustomCxxRulesDefinition, ensuring proper display of custom sources on the web server. Signed-off-by: qinyong <[email protected]>
|
Hi @smileQiny, thx for providing this. I will review it … |
guwirth
changed the title
guwirth
approved these changes
Mar 4, 2024
|
@smileQiny thx for providing this, I merged this bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CxxSquidSensor.saveViolationswas always usingCheckList.REPOSITORY_KEY(repository key=cxx) to create new issues. In case aCustomCxxRulesDefinitionwas using a different repository key this was not taken into account.The fix is related to #2642.
This change is