Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid: save metrics slow #2520

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented May 9, 2023

try to solve performance issue with squid save (#2502)


This change is Reviewable

try to solve performance issue with squid save
@guwirth guwirth added the bug label May 9, 2023
@guwirth guwirth added this to the 2.1.1 milestone May 9, 2023
@guwirth guwirth self-assigned this May 9, 2023
@guwirth guwirth changed the title squid save slow squid: save metrics slow May 9, 2023
@Nekto89
Copy link
Contributor

Nekto89 commented May 9, 2023

I've tried building it locally but "mvn clean install" gives error. Is there some link that I can use to download prebuilt plugin?

[ERROR] Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.034 s <<< FAILURE! - in com.sonar.cxx.sslr.impl.typed.InterceptorTest
[ERROR] requires_final_methods_to_be_non_public  Time elapsed: 0.019 s  <<< FAILURE!
java.lang.AssertionError:

Expecting actual throwable to be an instance of:
  java.lang.VerifyError
but was:
  java.lang.IncompatibleClassChangeError: class GeneratedBySSLR overrides final method com.sonar.cxx.sslr.impl.typed.InterceptorTest$PublicFinalMethod.m()Ljava/lang/Object;
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:874)
        ...(73 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
        at com.sonar.cxx.sslr.impl.typed.InterceptorTest.requires_final_methods_to_be_non_public(InterceptorTest.java:170)

UPD nvm, I was able to build it with Java JDK 11 instead of 17. I will try it today.

@guwirth
Copy link
Collaborator Author

guwirth commented May 9, 2023

@guwirth guwirth merged commit 1345a4d into SonarOpenCommunity:master May 9, 2023
@guwirth guwirth deleted the squid-save branch June 7, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants