Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring coverage sensors #1895

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Refactoring coverage sensors #1895

merged 1 commit into from
Sep 28, 2020

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Jun 10, 2020 •
edited
Loading

  • split into own sensors: use 'sonar.cxx.bullseye.reportPaths', 'sonar.cxx.cobertura.reportPaths', 'sonar.cxx.vscoveragexml.reportPaths' or 'sonar.cxx.ctctxt.reportPaths'
  • SonarQube will merge results of different reports and sensors
  • add warning for deprecated configuration property 'sonar.cxx.coverage.reportPath'
  • Remove coverage cache: Sensor now reads reports by project and no longer by module. Reports are no longer read multiple times.
  • improve logging
  • update integration tests to use new configuration properties

deprecate:

sonar.cxx.coverage.reportPath

new:

sonar.cxx.bullseye.reportPaths
sonar.cxx.cobertura.reportPaths
sonar.cxx.vscoveragexml.reportPaths
sonar.cxx.ctctxt.reportPaths

This change is Reviewable

@guwirth guwirth added this to the 2.0.0 milestone Jun 10, 2020
@guwirth guwirth changed the title Refactoring coverage Refactoring coverage sensors Jun 10, 2020
@guwirth guwirth mentioned this pull request Aug 13, 2020
Merged
@guwirth guwirth force-pushed the refactoring-coverage branch from 9176874 to 33f59a6 Compare September 26, 2020 18:45
@guwirth
- split into own sensors: use 'sonar.cxx.bullseye.reportPaths', 'sona…
822173b 
…r.cxx.cobertura.reportPaths', 'sonar.cxx.vscoveragexml.reportPaths' or 'sonar.cxx.ctctxt.reportPaths'

- add warning for deprecated configuration property 'sonar.cxx.coverage.reportPath'
- Remove coverage cache: Sensor now reads reports by project and no longer by module. Reports are no longer read multiple times.
- improve logging
- update integration tests to use new configuration properties
@guwirth guwirth force-pushed the refactoring-coverage branch from c844be3 to 822173b Compare September 28, 2020 08:20
@ghost
Copy link

ghost commented Sep 28, 2020

DeepCode's analysis on #822173 found:

  • ⚠️ 1 warning, ℹ️ 3 minor issues. 👇

Top issues

Description Example fixes
Use File.separator instead of / Occurrences: 🔧 Example fixes
Use java.util.ArrayList instead of java.util.LinkedList. Using java.util.LinkedList can lead to unnecessary performance overhead if the list is randomly accessed. Occurrences: 🔧 Example fixes
The expression inside debug will be computed even if the log level is not high enough for the message to be logged. This will slow the application down in vain. Consider checking the log level before evaluating the expression. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@guwirth guwirth merged commit ffd9964 into SonarOpenCommunity:master Sep 28, 2020
@guwirth guwirth self-assigned this Oct 2, 2020
@guwirth guwirth mentioned this pull request Oct 2, 2020
Closed
@guwirth guwirth deleted the refactoring-coverage branch November 30, 2020 08:53
@trzecieu
Copy link

trzecieu commented Mar 8, 2022

If someone is confused like I was: When you used XML output from gcovr, now sonar.cxx.cobertura.reportPaths is the right replacement for you.

@guwirth
Copy link
Collaborator Author

guwirth commented Mar 9, 2022

Hi @trzecieu,

thanks for your feedback!

What exactly is confusing?
How can we improve our Wiki?

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@guwirth guwirth

Labels
enhancement
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@guwirth @trzecieu