Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow argument arrays in JSON Compilation Database #1789

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Allow argument arrays in JSON Compilation Database #1789

merged 1 commit into from
Jan 20, 2020

Conversation

tisoft
Copy link
Contributor

@tisoft tisoft commented Jan 17, 2020 •
edited
Loading

according to the spec the arguments are a list of strings. Bear generates such files.

This change is backwards compatible.

Fixes #1745

This change is Reviewable

@guwirth guwirth added this to the 1.3.2 milestone Jan 18, 2020
guwirth
guwirth approved these changes Jan 18, 2020
View reviewed changes
Copy link
Collaborator

@guwirth guwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisoft thanks for this PR. For me it looks good. I like the fact that the solution is backward compatible.

@guwirth guwirth merged commit 7a07985 into SonarOpenCommunity:master Jan 20, 2020
@tisoft tisoft deleted the argument_as_array branch January 20, 2020 07:24
@guwirth guwirth changed the title Allow argument arrays in JsonCompilationDatabaseCommandObject Allow argument arrays in SON Compilation Database Jan 28, 2020
@guwirth guwirth changed the title Allow argument arrays in SON Compilation Database Allow argument arrays in JSON Compilation Database Jan 28, 2020
@guwirth guwirth mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guwirth guwirth guwirth approved these changes

@ivangalkin ivangalkin Awaiting requested review from ivangalkin

@jmecosta jmecosta Awaiting requested review from jmecosta

Assignees

@tisoft tisoft

Labels
enhancement
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.

JSON Compilation Database not handling array arguments
2 participants
@tisoft @guwirth