support gcc warnings without rule id #1708
Conversation
| public static final String DEFAULT_REGEX_DEF | ||
| = "(?<file>.*):(?<line>[0-9]+):[0-9]+:\\x20warning:\\x20(?<message>.*)\\x20\\[(?<id>.*)\\]"; | ||
| = "(?<file>.*):(?<line>[0-9]+):[0-9]+:\\x20warning:\\x20(?<message>.*?)(\\x20\\[(?<id>.*)\\])?\\s*$"; |
There was a problem hiding this comment.
Are all messages always in one line?
Maybe regex would be better (with id | without id)?
There was a problem hiding this comment.
In my understanding all the warnings look either like:
main.c:11:6: warning: unused variable 'i' [-Wunused-variable]where the id is the corresponding switch param (-Wunused-variable) ormain.c:7:1: warning: no semicolon at end of struct or unionwhere the id part is missing.
The regex match both of them.
By default warning messages are on one line, The user can force warning messages to be on several lines (if using for example -fmessage-length switch, but then current actual regex won't match either).
A named group can only appears once. So it's not possible to duplicate the beginning of the regex and if I use something like:
(?<file>.*):(?<line>[0-9]+):[0-9]+:\\x20warning:\\x20(?<message>.*)(\\x20\\[(?<id>.*)\\])?or(?<file>.*):(?<line>[0-9]+):[0-9]+:\\x20warning:\\x20(?<message>.*)((\\x20\\[(?<id>.*)\\])|(?!(\\x20\\[.*\\])))(matching id or not matching id)
The id is not recognized anymore.
I solved the problem using the greedy (?) and non-greedy (*?) operators and forcing to match the last part of the line.
| @@ -70,6 +71,9 @@ protected String getRegex(final SensorContext context) { | |||
|
|
|||
| @Override | |||
| protected String alignId(String id) { | |||
There was a problem hiding this comment.
Add short description why we need this special case.
| @@ -32,8 +32,9 @@ | |||
| public static final String REPORT_REGEX_DEF = "gcc.regex"; | |||
| public static final String REPORT_CHARSET_DEF = "gcc.charset"; | |||
| public static final String DEFAULT_CHARSET_DEF = "UTF-8"; | |||
| public static final String DEFAULT_ID = "enabled by default"; | |||
There was a problem hiding this comment.
Normal message keys should have no blanks. Maybe we should change it in XML file? Just default.
Is Code Smell / Critical / 5min the right default?
There was a problem hiding this comment.
For now all the gcc rules have the same type/severity/remediation effort.
I agree this should be questioned, but I suggest to address that in another PR.
At first I thought I would add a new rule, but then I found this one enabled by default, which does not correspond to any matching gcc warning id (all other id looks like -Wsomething -- i.e. the gcc activation parameter).
If you think it's better to change the id, I'm fine.
|
@stalb thanks looks good except the missing unit test. Can you please add one to avoid future regressions. |
stalb
force-pushed
the
feature/gcc_warning_without_id
branch
from
30b4f34 to
ea11d5b
Compare
guwirth
changed the title
close #1703
Problem:
Some gcc warnings don't have anything to match with a id rule.
In that case the default regex doesn't match and there is no id to match with a rule key
What I have done:
This change is