CxxPreprocessor: fix handling of SquidAstVisitorContext #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `SquidAstVisitorContext::getFile()` never returns `null` during productive execution * the only exception is preprocessing inside of preprocessor's constructor (error-prone design in my humble opinion) * Fixes: * wrong assumptions in `CxxPreprocessor` were fixed * documentation was added * poorly parametrized mocks were fixed in the unit tests * minor refactoring
* remove wrong is-null checks (although I hope, that SonarOpenCommunity#1638 will be merged and we could remove the code completely)
|
@ivangalkin looks good. And yes, maybe there is a better solution how to add default macros and config settings to preprocessor. |
guwirth
approved these changes
Dec 29, 2018
ivangalkin
added a commit
to ivangalkin/sonar-cxx
that referenced
this pull request
Jan 10, 2019
* org.sonar.sslr.toolkit.ConfigurationModel doesn't receive the file path of the processed file * file path plays important role for the preprocessor * pass a dummy path fixes SonarOpenCommunity#1662
ivangalkin
added a commit
to ivangalkin/sonar-cxx
that referenced
this pull request
Jan 10, 2019
* org.sonar.sslr.toolkit.ConfigurationModel doesn't receive the file path of the processed file * file path plays important role for the preprocessor * pass a dummy path fixes SonarOpenCommunity#1662
guwirth
added a commit
that referenced
this pull request
Jan 11, 2019
fix: sslr-cxx-toolkit fails after #1645
Bertk
pushed a commit
to Bertk/sonar-cxx
that referenced
this pull request
Jun 22, 2019
* org.sonar.sslr.toolkit.ConfigurationModel doesn't receive the file path of the processed file * file path plays important role for the preprocessor * pass a dummy path fixes SonarOpenCommunity#1662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SquidAstVisitorContext::getFile()never returnsnullduring productive executionthe only exception is preprocessing inside of preprocessor's constructor
(error-prone design in my humble opinion)
Fixes:
CxxPreprocessorwere fixedThis change is