add 'cannot find the file...' only once

[guwirth]

• reduce the noise in LOG file
• add 'cannot file the file...' only once per file in CxxIssuesReportSensor

---

This change is 

[ivangalkin]

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guwirth)

---

cxx-sensors/src/main/java/org/sonar/cxx/sensors/utils/CxxIssuesReportSensor.java, line 145 at r1 (raw file):

LOG.warn

I know, that the previous severity (DEBUG) doesn't match with the severity from below (WARN). This doesn't look right. However I disagree with making this trace to WARN. The reason is that for multi-module projects there will be too many warnings.

I've described this situation using the coverage import as example. Please see #1508 (comment) . Similar can happen when importing one single (large) e.g. cppcheck report for multiple (small) modules.

Not sure which solution would be correct. Ideally there should be some code like...

   if processing_one_of_many_modules(sensorContext):
       LOG.debug()
   else:
       # processing the single-module project
       LOG.warn()

... I don't know if it's possible to determine the condition processing_one_of_many_modules reliable.

[guwirth]

@ivangalkin this PR is an improvement to the current state. Current solution add warnings even if files are already in notFoundFiles. I moved the warning to getInputFileIfInProject. Maybe not perfect but much better.

[ivangalkin]

@guwirth I agree, it's better. After some second look at the functions

• getInputFileIfInProject() and
• createNewIssueLocationFile()

I believe, that the first one will produce less noise. Some background.

• function getInputFileIfInProject() is a service function, which might be called multiple times per project/module. It's used in all sensors implicitly (because CxxIssuesReportSensor is a base class) and in some of them explicitly:
  • CppcheckParserV2.java
  • CxxDrMemorySensor.java
  • CxxValgrindSensor.java

That means, that the same warning for some particular file path might appear multiple times per module/project. But it appears only once per sensor, because results of getInputFileIfInProject() are cached in notFoundFiles;

• function createNewIssueLocationFile() has a similar problem. It might be also called from multiple sensors + each sensor might call this function multiple time. However the warning was not associated with the cache. So it's potentially more verbose.

So it's ok from my side.

[ivangalkin]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guwirth)

[guwirth]

@ivangalkin thx. Let's test it and further improve it in next version...