unify checks for user-provided regular expressions + random refactoring #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guwirth
approved these changes
Nov 30, 2018
|
@ivangalkin please rebase that I can merge it. |
* check all user-provided regular expressions if they are empty -> throw if empty or not compilable * avoid string comparisor for token value -> compare token types if possible * unify and simplify the read functionality if content of entire file is required * minor refactoring
ivangalkin
force-pushed
the
regex_refactoring
branch
from
c0113cd to
1956adb
Compare
done, thank you in advance |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> throw if empty or not compilable
-> compare token types if possible
This change is