Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality flaws 2 #1606

Merged
merged 3 commits into from
Nov 30, 2018
Merged

Quality flaws 2 #1606

merged 3 commits into from
Nov 30, 2018

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Nov 29, 2018

This change is Reviewable

@guwirth guwirth added this to the 1.2.1 milestone Nov 29, 2018
@guwirth guwirth self-assigned this Nov 29, 2018
Copy link
Contributor

@ivangalkin ivangalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 236 of 236 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guwirth)


cxx-checks/src/main/java/org/sonar/cxx/checks/error/MissingIncludeFileCheck.java, line 22 at r1 (raw file):

package org.sonar.cxx.checks.error;

import com.sonar.sslr.api.AstNode;

how do you sort the imports? I use the built-in code style for eclipse and applying of "Source" -> "Organize Imports" (aka Ctrl-Shift-O) produces the import lists like on the left side. I have no strong preference about the sorting order It would be nice if developers would use the same one.


cxx-sensors/src/main/java/org/sonar/cxx/sensors/tests/xunit/XunitReportParser.java, line 126 at r1 (raw file):

  public void parseTestSuiteTag(SMInputCursor testSuiteCursor)
   throws XMLStreamException {

which max. line length do you use?

@guwirth
Copy link
Collaborator Author

guwirth commented Nov 30, 2018

@ivangalkin I'm using NetBeans IDE 8.2

  • executed "Source/Organize Imports"
  • executed "Source/Organize Members"
  • executed "Source/Format"
  • line length is 120 (same as on SonarCloud)

@guwirth guwirth merged commit 5d8c77b into SonarOpenCommunity:master Nov 30, 2018
@guwirth
Copy link
Collaborator Author

guwirth commented Nov 30, 2018

Have now a lot of: "The members of an interface or class declaration should appear in a pre-defined order"
Order seems to be different in NetBeans and SonarCloud rules.

@guwirth guwirth mentioned this pull request Dec 21, 2018
@guwirth guwirth deleted the quality-flaws-2 branch December 27, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants