Refactor CxxFileLinesVisitor #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* collections for line tracking don't have not to be static * collections don't have to be sorted for each token * it's sufficient to sort / filter duplicates at file end * types of tokens must be compared rather than string values * misc refactoring
guwirth
requested changes
Nov 26, 2018
cxx-sensors/src/main/java/org/sonar/cxx/sensors/visitors/CxxFileLinesVisitor.java
Outdated
Show resolved
Hide resolved
cxx-sensors/src/main/java/org/sonar/cxx/sensors/visitors/CxxFileLinesVisitor.java
Outdated
Show resolved
Hide resolved
cxx-sensors/src/main/java/org/sonar/cxx/sensors/visitors/CxxFileLinesVisitor.java
Outdated
Show resolved
Hide resolved
| @@ -97,14 +123,14 @@ public void visitToken(Token token) { | |||
| return; | |||
There was a problem hiding this comment.
There is issue #1220. Could this be the reason?
There was a problem hiding this comment.
I'm not sure if there is a connection between the metrics and the coverage data. It requires additional investigation.
| if (value != null && !"{".equals(value) && !"default".equals(value) && !"case".equals(value)) { | ||
| EXECUTABLE_LINES.add(astNode.getTokenLine()); | ||
| final TokenType type = astNode.getToken().getType(); | ||
| if (!CxxPunctuator.CURLBR_LEFT.equals(type) && !CxxKeyword.DEFAULT.equals(type) && !CxxKeyword.CASE.equals(type)) { |
There was a problem hiding this comment.
not worth in this case IMHO
| LOG.debug(" linesOfComments: '{}'", LINES_OF_COMMENTS); | ||
| LOG.debug(" executableLines: '{}'", Sets.newHashSet(executableLines)); | ||
| LOG.debug(" linesOfCode: '{}'", Sets.newHashSet(linesOfCode)); | ||
| LOG.debug(" linesOfComments: '{}'", Sets.newHashSet(linesOfComments)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Wondering if it would not be better to clear lists also here to safe memory. Don't know how long the visitor does life?
There was a problem hiding this comment.
The lifetime of these containers was extended artificially in order to ease testing. I've rewritten tests instead
guwirth
approved these changes
Nov 27, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is