Skip to content

Commit

Permalink
sdist build: let pip install put ~everything from tar.gz to site-pack…
Browse files Browse the repository at this point in the history
…ages

(well, not everything, only files in electrum/ (so e.g. not contrib))
See comment in setup.py.

E.g. we have been including the www/ folder in the tar.gz but have not been installing it
to site-packages. Now we do.
Or we have been including the kivy GUI files in the tar.gz but not installing them.
Now we do.

I like this because it simplifies setup.py and should be easier to reason about too.

should fix spesmilo#7089 (at least when using the tar.gz)
  • Loading branch information
SomberNight committed Mar 27, 2021
1 parent 472d112 commit 2cb4e56
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,17 +79,10 @@
package_dir={
'electrum': 'electrum'
},
package_data={
'': ['*.txt', '*.json', '*.ttf', '*.otf', '*.csv'],
'electrum': [
'wordlist/*.txt',
'locale/*/LC_MESSAGES/electrum.mo',
'lnwire/*.csv',
],
'electrum.gui': [
'icons/*',
],
},
# Note: MANIFEST.in lists what gets included in the tar.gz, and the
# package_data kwarg lists what gets put in site-packages when pip installing the tar.gz.
# By specifying include_package_data=True, MANIFEST.in becomes responsible for both.
include_package_data=True,
scripts=['electrum/electrum'],
data_files=data_files,
description="Lightweight Bitcoin Wallet",
Expand Down

0 comments on commit 2cb4e56

Please sign in to comment.