bug: Sks menu button fix #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm, that flutter analyze error doesnt appear on my side and it rather isn't related with my code, but I think I can fix this... |
|
dunno, they say here https://pub.dev/documentation/wiredash/latest/wiredash/WiredashController/show.html that this show uses future, but on my side locally it doesnt XD and on main it is also assumed that it doesn't. There is probably some issue with pubsec? This is my version of that function. The fix would be probably adding async and await here (lib/features/analytics/show_feedback_tile.dart):
|
simon-the-shark
force-pushed
the
Sks-button-fix
branch
from
f4855db to
901210c
Compare
simon-the-shark
force-pushed
the
main
branch
from
e4a03b4 to
5214b32
Compare
simon-the-shark
force-pushed
the
Sks-button-fix
branch
from
901210c to
a2f3edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed that unclickable button issue. The problem was that"Pokaż ostatnio dostępne menu" button was under the image, but i managed to make it clickable and I just moved the whole section up. This is the outcome:
And without the button, if the latest menu is not available:
