Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/amenities section #486

Merged
merged 8 commits into from
Dec 15, 2024
Merged

Feat/amenities section #486

merged 8 commits into from
Dec 15, 2024

Conversation

24bartixx
Copy link
Member

@24bartixx 24bartixx commented Dec 11, 2024

What has been done

  • change the storey icon
  • add proper icons to the amenities section
  • display of phone numbers
black option

Be careful

I used this icon for the sign language interpreter. I am not sure whether I can... I cannot use one from the digital guide website because none of the buildings is actually using it.

Question

Which accessibility button? I'd personally go for option 3 or 4

option 1 option 2 option 3 option 4 option 5

@24bartixx 24bartixx linked an issue Dec 11, 2024 that may be closed by this pull request
@mikolaj-jalocha

This comment was marked as resolved.

@24bartixx

This comment was marked as resolved.

@mikolaj-jalocha

This comment was marked as resolved.

@simon-the-shark
Copy link
Member

@pbonar do you think the orange or black icons look better in this section?

@24bartixx

This comment was marked as resolved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 15 changed files in this pull request and generated no suggestions.

Files not reviewed (5)
  • lib/features/digital_guide_view/amenities/presentation/amenities_expansion_tile_content.dart: Language not supported
  • lib/features/digital_guide_view/general_info/presentation/digital_guide_view.dart: Language not supported
  • lib/features/digital_guide_view/general_info/presentation/widgets/headlines_section.dart: Language not supported
  • lib/features/home_view/widgets/science_clubs_section.dart: Language not supported
  • lib/l10n/app_pl.arb: Language not supported
@simon-the-shark

This comment was marked as resolved.

@pbonar
Copy link
Contributor

pbonar commented Dec 11, 2024

yeah I agree, I think black icons in the section, however tbh the button on the top right should be the same color as the button on the left so that the whole top nav has the same color, but that's just my opinion

@24bartixx
Copy link
Member Author

yeah I agree, I think black icons in the section, however tbh the button on the top right should be the same color as the button on the left so that the whole top nav has the same color, but that's just my opinion

Do you mean to change the accessibility button (with the wheelchair icon) color to orange?

@pbonar
Copy link
Contributor

pbonar commented Dec 11, 2024

yeah that's what I mean, I think it would look better, we can try it out

@24bartixx
Copy link
Member Author

yeah that's what I mean, I think it would look better, we can try it out

Okay I'll try to change and see how it looks as this button is not in the scope of any other ongoing task. Thank You <3

@24bartixx
Copy link
Member Author

@mikolaj-jalocha @simon-the-shark @pbonar
Please tell me which accessibility button option is the best
There are 5 options in the PR description above

@mikolaj-jalocha
Copy link
Member

@mikolaj-jalocha @simon-the-shark @pbonar Please tell me which accessibility button option is the best There are 5 options in the PR description above

3

@simon-the-shark
Copy link
Member

3 but imo the padding needs changing on all of them

@24bartixx
Copy link
Member Author

Option number 3 is already applied in the PR

@simon-the-shark
Copy link
Member

Are we ready to merge?

@mikolaj-jalocha mikolaj-jalocha self-requested a review December 12, 2024 09:38
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment

Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final touch. Please remember about rebase with main (some important files regarding urls have changed)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • lib/features/digital_guide_view/amenities/presentation/amenities_expansion_tile_content.dart: Language not supported
  • lib/features/digital_guide_view/general_info/presentation/digital_guide_view.dart: Language not supported
  • lib/features/digital_guide_view/general_info/presentation/widgets/accessibility_button.dart: Language not supported
  • lib/features/digital_guide_view/general_info/presentation/widgets/headlines_section.dart: Language not supported
  • lib/features/home_view/widgets/science_clubs_section.dart: Language not supported
  • lib/l10n/app_pl.arb: Language not supported
@simon-the-shark
Copy link
Member

what's the status here?

@24bartixx
Copy link
Member Author

what's the status here?

I'll update it tonight and we are ready to merge

Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

@mikolaj-jalocha mikolaj-jalocha self-requested a review December 15, 2024 14:02
@mikolaj-jalocha mikolaj-jalocha merged commit 71cdaf0 into main Dec 15, 2024
2 checks passed
@mikolaj-jalocha mikolaj-jalocha deleted the feat/amenities-section branch December 15, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat/amenities section; digital guide screen
4 participants