-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/amenities section #486
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@pbonar do you think the orange or black icons look better in this section? |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 15 changed files in this pull request and generated no suggestions.
Files not reviewed (5)
- lib/features/digital_guide_view/amenities/presentation/amenities_expansion_tile_content.dart: Language not supported
- lib/features/digital_guide_view/general_info/presentation/digital_guide_view.dart: Language not supported
- lib/features/digital_guide_view/general_info/presentation/widgets/headlines_section.dart: Language not supported
- lib/features/home_view/widgets/science_clubs_section.dart: Language not supported
- lib/l10n/app_pl.arb: Language not supported
This comment was marked as resolved.
This comment was marked as resolved.
yeah I agree, I think black icons in the section, however tbh the button on the top right should be the same color as the button on the left so that the whole top nav has the same color, but that's just my opinion |
Do you mean to change the accessibility button (with the wheelchair icon) color to orange? |
yeah that's what I mean, I think it would look better, we can try it out |
Okay I'll try to change and see how it looks as this button is not in the scope of any other ongoing task. Thank You <3 |
@mikolaj-jalocha @simon-the-shark @pbonar |
3 |
3 but imo the padding needs changing on all of them |
Option number 3 is already applied in the PR |
Are we ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment
lib/features/digital_guide_view/general_info/presentation/digital_guide_view.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final touch. Please remember about rebase with main (some important files regarding urls have changed)
lib/features/digital_guide_view/general_info/presentation/digital_guide_view.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (6)
- lib/features/digital_guide_view/amenities/presentation/amenities_expansion_tile_content.dart: Language not supported
- lib/features/digital_guide_view/general_info/presentation/digital_guide_view.dart: Language not supported
- lib/features/digital_guide_view/general_info/presentation/widgets/accessibility_button.dart: Language not supported
- lib/features/digital_guide_view/general_info/presentation/widgets/headlines_section.dart: Language not supported
- lib/features/home_view/widgets/science_clubs_section.dart: Language not supported
- lib/l10n/app_pl.arb: Language not supported
what's the status here? |
I'll update it tonight and we are ready to merge |
cead1ab
to
5bcbe00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment
What has been done
Be careful
I used this icon for the sign language interpreter. I am not sure whether I can... I cannot use one from the digital guide website because none of the buildings is actually using it.
Question
Which accessibility button? I'd personally go for option 3 or 4