Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add report button functionality - open email app #484

Merged
merged 11 commits into from
Dec 11, 2024
Merged

feat: add report button functionality - open email app #484

merged 11 commits into from
Dec 11, 2024

Conversation

24bartixx
Copy link
Member

@24bartixx 24bartixx commented Dec 11, 2024 •
edited
Loading

What has been done

  • navigate to an email app on the report button click
  • handle digital guide data source tap
Orange option final toast

@mikolaj-jalocha
Copy link
Member

Imo toast should be shown at the bottom of the screen with transparent or white background. You can consider snackbar as well :)

Ps i like way the pr has been described:)

@24bartixx

This comment was marked as outdated.

Sign in to view
@24bartixx

This comment was marked as resolved.

Sign in to view
@mikolaj-jalocha

This comment was marked as resolved.

Sign in to view
@24bartixx 24bartixx linked an issue Dec 11, 2024 that may be closed by this pull request
feat (digital-guide): implement report change functionality #471
Closed
@24bartixx

This comment was marked as outdated.

Sign in to view
@24bartixx 24bartixx marked this pull request as draft December 11, 2024 13:37
@mikolaj-jalocha mikolaj-jalocha changed the title feat: add report button functionality - open email app feat: add report button functionality - open email app - WIP 🛠️ Dec 11, 2024
@24bartixx 24bartixx marked this pull request as ready for review December 11, 2024 13:43
@24bartixx 24bartixx changed the title feat: add report button functionality - open email app - WIP 🛠️ feat: add report button functionality - open email app Dec 11, 2024
mikolaj-jalocha
mikolaj-jalocha requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments

...res/digital_guide_view/general_info/presentation/widgets/digital_guide_data_source_link.dart Outdated Show resolved Hide resolved
@24bartixx 24bartixx marked this pull request as draft December 11, 2024 16:13
@24bartixx 24bartixx changed the title feat: add report button functionality - open email app feat: add report button functionality - open email app - WIP 🛠️ Dec 11, 2024
@24bartixx 24bartixx marked this pull request as ready for review December 11, 2024 17:15
@24bartixx 24bartixx changed the title feat: add report button functionality - open email app - WIP 🛠️ feat: add report button functionality - open email app Dec 11, 2024
mikolaj-jalocha
mikolaj-jalocha requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final touches

lib/features/digital_guide_view/general_info/presentation/widgets/report_change_button.dart Outdated Show resolved Hide resolved
...res/digital_guide_view/general_info/presentation/widgets/digital_guide_data_source_link.dart Outdated Show resolved Hide resolved
mikolaj-jalocha
mikolaj-jalocha previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good work. Tbh simillar mechanism could be implemented everywhere else in the app when email is requested. Fell free to embrace it if u have enough time

lib/features/digital_guide_view/general_info/presentation/widgets/report_change_button.dart Outdated
Comment on lines 28 to 30
if (!await ref.launch(
"mailto:${context.localize.report_change_email}?subject=${Uri.encodeComponent(context.localize.report_change_subject)}",
)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be stored inside variable but i leave it up to you if u want to change it.

@mikolaj-jalocha mikolaj-jalocha added the enhancement New feature or request label Dec 11, 2024
@mikolaj-jalocha mikolaj-jalocha merged commit 489b8a0 into main Dec 11, 2024
2 checks passed
@mikolaj-jalocha mikolaj-jalocha deleted the feat/report-change-functionality branch December 11, 2024 19:17
@mikolaj-jalocha mikolaj-jalocha mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikolaj-jalocha mikolaj-jalocha mikolaj-jalocha approved these changes

Assignees

@24bartixx 24bartixx

Labels
enhancement New feature or request
Projects
ToPWR
Status: Done
Milestone
v1.2.0 - Mr. Shark, We Have to Cook
Development

Successfully merging this pull request may close these issues.

feat (digital-guide): implement report change functionality
2 participants
@24bartixx @mikolaj-jalocha