Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove bottom nav bar strip #475

Merged
merged 1 commit into from
Dec 8, 2024
Merged

fix: Remove bottom nav bar strip #475

merged 1 commit into from
Dec 8, 2024

Conversation

BombardierBulge
Copy link
Contributor

  • removed safezone
  • added padding to last element

@BombardierBulge BombardierBulge self-assigned this Dec 8, 2024
@BombardierBulge BombardierBulge linked an issue Dec 8, 2024 that may be closed by this pull request
fix/ remove bottom nav bar strip #453
Closed
@BombardierBulge BombardierBulge changed the title Remove bottom nav bar strip fix: Remove bottom nav bar strip Dec 8, 2024
@BombardierBulge BombardierBulge marked this pull request as ready for review December 8, 2024 15:25
@BombardierBulge
Copy link
Contributor Author

I don't know why there are so many commits 😭

@simon-the-shark
Copy link
Member

I don't know why there are so many commits 😭

Next time just make a clean branch from the main. But I'll fix this in a second

@simon-the-shark simon-the-shark force-pushed the remove-bottom-nav-bar-strip branch from 3a67605 to 514d5aa Compare December 8, 2024 17:44
@simon-the-shark
Copy link
Member

Zrzut ekranu 2024-12-8 o 18 44 06
next time you can also add ss to the PR

simon-the-shark
simon-the-shark approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but good job, LGTM!

@simon-the-shark simon-the-shark added the bug Something isn't working label Dec 8, 2024
@simon-the-shark simon-the-shark merged commit aa6c7d8 into main Dec 8, 2024
2 checks passed
@simon-the-shark simon-the-shark deleted the remove-bottom-nav-bar-strip branch December 8, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-the-shark simon-the-shark simon-the-shark approved these changes

@mikolaj-jalocha mikolaj-jalocha Awaiting requested review from mikolaj-jalocha

@tomasz-trela tomasz-trela Awaiting requested review from tomasz-trela

Assignees

@BombardierBulge BombardierBulge

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0 - Mr. Shark, We Have to Cook
Development

Successfully merging this pull request may close these issues.

fix/ remove bottom nav bar strip
2 participants
@BombardierBulge @simon-the-shark