Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix padding #445

Merged
merged 4 commits into from
Nov 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/config/ui_config.dart
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ abstract class SksConfig {
static const sizedBoxWidth = 5.0;
static const radius = 8.0;
static const innerPadding = EdgeInsets.symmetric(horizontal: 8, vertical: 4);
static const outerPaddingLarge = EdgeInsets.only(right: 24, bottom: 2);
static const outerPadding = EdgeInsets.only(right: 12, bottom: 2);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class NotificationButton extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Padding(
padding: SksConfig.outerPadding,
padding: SksConfig.outerPaddingLarge,
child: MySplashTile(
// TODO(simon-the-shark): show dialog about our future intented use of notifications
onTap: requestFCMPermission,
Expand Down
5 changes: 5 additions & 0 deletions lib/features/sks-menu/presentation/sks_menu_screen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ class _SKSMenuLottieAnimation extends StatelessWidget {
Widget build(BuildContext context) {
Logger().e(error.toString());
return Scaffold(
appBar: DetailViewAppBar(
actions: const [
SksUserDataButton(),
],
),
body: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
Expand Down