Feat/create digital guide screen #442

24bartixx · 2024-11-29T17:21:03Z

Changes

Mock UI for building detail page following https://www.figma.com/design/33ofdGYbBzWvDi2MabxIc1/ToPWR-(imported)
API with authorization and models
basic info filled with data from API
API documentation (readme.md) in .../data package
amenities expansion tile - WIP ⚒️
surrounding expansion tile - WIP ⚒️
No animations

mikolaj-jalocha

Nice part of code actually!
I left few notes ( usually regarding naming) and questions of mine (ie. why some files did change), Wherever possible, it's good to use colors and text styles defined in our theme.

lib/features/building_detail_view/presentation/building_detail_view.dart

lib/config/ui_config.dart

lib/features/building_detail_view/presentation/widgets/accessible_button.dart

lib/l10n/app_pl.arb

lib/widgets/change_report_button.dart

lib/widgets/detail_views/contact_section.dart

tomasz-trela

Great job! Your code quality was excellent. I have some feedback to share with you.

lib/features/building_detail_view/presentation/widgets/building_data_source_link.dart

lib/features/building_detail_view/presentation/widgets/building_features_section.dart

lib/features/home_view/widgets/science_clubs_section.dart

lib/widgets/change_report_button.dart

tomasz-trela · 2024-12-02T18:38:08Z

I'll review your code when you finish whole task.

lib/features/digital_guide_view/general_info/data/repository/digital_guide_repository.dart

…d remove error handling from fetching imageUrl

…splay

simon-the-shark

good job here! I think we're coming close to merging, just change Column to listview.builder; change child delegate to builder delegate and we can prolly merge.

…etage

24bartixx · 2024-12-08T19:20:47Z

I think it's done 😉

...res/digital_guide_view/general_info/presentation/widgets/digital_guide_features_section.dart

simon-the-shark

Finally! Good job, looks good to me

24bartixx added 5 commits November 28, 2024 01:06

chore: add temp button on main screen

300a8f0

feat: add simple view and navigation

f3a1dfd

feat: initially implement UI in building detail view

338ab44

feat: add building info section UI

40b3e24

feat: add extenstion tiles, adjust building info section, lint rules

413168f

24bartixx linked an issue Nov 29, 2024 that may be closed by this pull request

feat/ create digital guide screen #423

Closed

simon-the-shark assigned 24bartixx Nov 29, 2024

simon-the-shark requested review from mikolaj-jalocha and tomasz-trela November 29, 2024 17:26

simon-the-shark added the enhancement New feature or request label Nov 29, 2024

simon-the-shark added this to the v1.2.0 - Mr. Shark, We Have to Cook milestone Nov 29, 2024

simon-the-shark removed a link to an issue Nov 29, 2024

feat/ create digital guide screen #423

Closed

simon-the-shark linked an issue Nov 29, 2024 that may be closed by this pull request

feat/ add guide digital screen first UI mock [SUBTASK] #443

Closed

This comment was marked as outdated.

Sign in to view

fix: lint rules

ef6a564

This comment was marked as outdated.

Sign in to view

mikolaj-jalocha requested changes Nov 29, 2024

View reviewed changes

tomasz-trela requested changes Nov 29, 2024

View reviewed changes

fix: review fixes

16efc60

24bartixx requested review from tomasz-trela and mikolaj-jalocha December 1, 2024 08:32

This comment was marked as outdated.

Sign in to view

24bartixx closed this Dec 1, 2024

This comment was marked as resolved.

Sign in to view

mikolaj-jalocha reopened this Dec 1, 2024

mikolaj-jalocha marked this pull request as draft December 3, 2024 10:19

mikolaj-jalocha changed the title ~~Feat/create digital guide screen~~ Feat/create digital guide screen - WIP 🛠️ Dec 3, 2024

This comment was marked as outdated.

Sign in to view

simon-the-shark reviewed Dec 7, 2024

View reviewed changes

lib/features/digital_guide_view/general_info/data/repository/digital_guide_repository.dart Outdated Show resolved Hide resolved

simon-the-shark reviewed Dec 7, 2024

View reviewed changes

lib/features/digital_guide_view/general_info/data/repository/digital_guide_repository.dart Outdated Show resolved Hide resolved

simon-the-shark reviewed Dec 7, 2024

View reviewed changes

lib/features/digital_guide_view/general_info/data/repository/digital_guide_repository.dart Outdated Show resolved Hide resolved

24bartixx and others added 3 commits December 7, 2024 13:40

refractor: combine imageUrl and digitalGuideResponse into on class an…

e6289e1

…d remove error handling from fetching imageUrl

fix: add error handling while fetching image url for other data to di…

9c5f32f

…splay

docs: update and improve readme.md for the feature

83ce62c

simon-the-shark linked an issue Dec 7, 2024 that may be closed by this pull request

feat/first api connection [SUBTASK] #473

Closed

simon-the-shark changed the title ~~Feat/create digital guide screen - WIP⚒️~~ Feat/create digital guide screen Dec 7, 2024

24bartixx added 2 commits December 7, 2024 14:39

fix: follow mock on Figma for accesibility button

533c659

merge: docs and accessibility button commit

f9e7e6f

This comment was marked as outdated.

Sign in to view

simon-the-shark reviewed Dec 8, 2024

View reviewed changes

24bartixx added 4 commits December 8, 2024 13:52

fix: reorganize assets svg

31c2b50

refractor: replace SliverChildListDeletage with SliverChildBuilderDel…

4a2242c

…etage

refractor: replace Columns with slivers

6bad09c

fix: lint rules and formatting

f76e5b1

24bartixx requested review from simon-the-shark and mikolaj-jalocha December 8, 2024 19:21

simon-the-shark reviewed Dec 8, 2024

View reviewed changes

...res/digital_guide_view/general_info/presentation/widgets/digital_guide_features_section.dart Outdated Show resolved Hide resolved

fix: ensure type safety

d9a103b

24bartixx requested a review from simon-the-shark December 8, 2024 20:18

simon-the-shark previously approved these changes Dec 8, 2024

View reviewed changes

Merge branch 'main' into feat/create-digital-guide-screen

4966461

simon-the-shark dismissed their stale review via 4966461 December 8, 2024 20:20

fix: post merge fix

b5646a7

simon-the-shark force-pushed the feat/create-digital-guide-screen branch from 51d90fa to b5646a7 Compare December 8, 2024 20:28

simon-the-shark merged commit cbf1c77 into main Dec 8, 2024
2 checks passed

simon-the-shark deleted the feat/create-digital-guide-screen branch December 8, 2024 20:30

simon-the-shark mentioned this pull request Dec 11, 2024

fix(digital-guide): improve visual aspect #485

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/create digital guide screen #442

Feat/create digital guide screen #442

24bartixx commented Nov 29, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mikolaj-jalocha left a comment

tomasz-trela left a comment

This comment was marked as outdated.

This comment was marked as resolved.

tomasz-trela commented Dec 2, 2024

This comment was marked as outdated.

This comment was marked as outdated.

simon-the-shark left a comment •

edited

Loading

24bartixx commented Dec 8, 2024

simon-the-shark left a comment

Feat/create digital guide screen #442

Feat/create digital guide screen #442

Conversation

24bartixx commented Nov 29, 2024 • edited Loading

Changes

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mikolaj-jalocha left a comment

Choose a reason for hiding this comment

tomasz-trela left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as resolved.

tomasz-trela commented Dec 2, 2024

This comment was marked as outdated.

This comment was marked as outdated.

simon-the-shark left a comment • edited Loading

Choose a reason for hiding this comment

24bartixx commented Dec 8, 2024

simon-the-shark left a comment

Choose a reason for hiding this comment

24bartixx commented Nov 29, 2024 •

edited

Loading

simon-the-shark left a comment •

edited

Loading