feat/ add loading screen for SKS Menu #427

BombardierBulge · 2024-11-24T02:41:14Z

replaced random animation loading indicator's with shimmer loading animation
look preview

* Feat: create sks menu screen - prototype * feat: create sks menu screen * feat(sks-menu): improve spacings and font * fix(sks-menu): fix sks url link * fix(sks-menu): remove bottom nav bar * feat (sks-menu): add data layer * chore (sks-menu): code cleanup * feat (sks-menu): pr fix --------- Co-authored-by: Szymon Kowaliński <[email protected]>

…c. (#414) Co-authored-by: Rafal Rejek <[email protected]>

* feat: add interval refresh on the sks people counter * refactor: add separate files for refresh on ref and consts add files: sks_people_live_consts.dart ref_extensions.dart change files: home_viev.dart: add SksAppBar to AppBar parkings_repository.dart, latest_sks_user_data_repository.dart: refactor code * refactor: delete unused imports

…treetmap.org URL (#417) See openstreetmap/operations#737

# Conflicts: # lib/features/navigator/app_router.dart # lib/features/sks-menu/data/models/sks_menu_data.dart # lib/features/sks-menu/data/repository/sks_menu_repository.dart # lib/features/sks-menu/presentation/sks_menu_screen.dart # lib/l10n/app_pl.arb

mikolaj-jalocha · 2024-11-24T07:50:01Z

@BombardierBulge please fix linter complaints (instructions in readme) and if possible please attach some screenshots.

When you're ready please request review from me or @tomasz-trela.

Good job!

tomasz-trela · 2024-11-24T15:14:30Z

There are some errors. We will do review later.

lib/features/sks-menu/presentation/widgets/sks_menu_view_loading.dart

mikolaj-jalocha

In the comparison with the first version code now looks extremely simple and clean. So, congrats on that.

In my opinion some parts of UI could be slightly better mapped into shimmer loading, but don't waste time on it..

Please see my comments about calculations (important) and private classes.

mikolaj-jalocha · 2024-11-30T13:05:45Z

lib/features/sks-menu/presentation/widgets/sks_menu_header.dart

@@ -49,3 +51,21 @@ class SksMenuHeader extends StatelessWidget {
    );
  }
 }
+
+class SksMenuHeaderLoading extends StatelessWidget {


This class could be private.

This class could be private and moved to sks_menu_view_loading

lib/features/sks-menu/presentation/widgets/sks_menu_tiles.dart

mikolaj-jalocha · 2024-11-30T13:06:58Z

lib/features/sks-menu/presentation/widgets/sks_menu_tiles.dart

@@ -74,3 +75,41 @@ class SksMenuDishDetailsTile extends StatelessWidget {
    );
  }
 }
+
+class SksMenuTilesLoading extends StatelessWidget {


This class could be private.

This class could be private and moved to sks_menu_view_loading

There was a problem accessing context.colorTheme.whiteSoap when SksMenuTilesLoading was moved to sks_menu_view_loading. How can I fix this?

White soap here is optional I guess (since we re using shimmer) , you can use whatever colour you prefer or use Colour consts (see my commit with sks menu or draft commit with chart)

100% certain. Colour here could be even pink, it completely doesnt matter

mikolaj-jalocha · 2024-11-30T13:07:06Z

lib/features/sks-menu/presentation/widgets/sks_menu_tiles.dart

+  }
+}
+
+class LoadingTitle extends StatelessWidget {


This class could be private

lib/features/sks-menu/presentation/widgets/sks_menu_view_loading.dart

lib/features/sks-menu/presentation/widgets/sks_menu_header.dart

mikolaj-jalocha · 2024-11-30T13:10:43Z

lib/features/sks-menu/presentation/widgets/sks_menu_view_loading.dart

+        separatorBuilder: (context, _) => const SizedBox(
+          height: 8,
+        ),
+        itemCount: 3,


I think we should made some kind of calculations to ensure that large screens are not in 80% blank.

Should i use MediaQuery.of(context).size.height or SksMenuConfig padding value in ui_config ?

Height here is ok. itemCount is what we re discussing. Please check ScrollableLoaderBuilder to determine how many items need to be displayed

simon-the-shark

About the calculations etc, I would reccomend checking out and reusing our ScrollableLoaderBuilder widget in some way @mikolaj-jalocha @BombardierBulge

* feat: caching_rest_response * chore/ format code * refactor/parametrize function * feat: condition * refactor/ meet review requirements * chore/ format code * feat: caching_rest_response * chore/ format code * refactor/parametrize function * feat: condition * refactor/ meet review requirements * chore/ format code * refactor/ unify rest clients * feat/ aditional comments and renaming

…eing checked recently

…ks website & adapt for new data format

…bsite

navigation_tab_view.dart: add revirew openStoreListing behavior to review button

* Add Wrap * Fix translation * Fix problem with Dialog on small screens --------- Co-authored-by: Rafal Rejek <[email protected]>

* feat: add lottie animation for sks menu * feat: adding statefull widget for showing the menu from the latest update * feat: changing to CircularProgressIndicator() for loading of sks menu and adding sks_old_menu text * feat: add sks menu loading * feat: sks menu not available message * chore: fix linter complaints * feat: show error on screen --------- Co-authored-by: mikolaj-jalocha <[email protected]>

* feat: navgation aware back button Co-authored-by: Szymon Kowaliński <[email protected]> * refactor: delete unused imports * fix(navigator): resolve race hazard related to view transistions duration --------- Co-authored-by: piwniczak2137 <[email protected]>

* /fix fix shadows on filter's screen * /fix fix shadows on filter's screen

simon-the-shark · 2024-12-02T13:48:37Z

About the calculations etc, I would reccomend checking out and reusing our ScrollableLoaderBuilder widget in some way @mikolaj-jalocha @BombardierBulge

What's the status on the PR? Did you check out the ScrollableLoaderBuilder in the codebase?

BombardierBulge · 2024-12-02T14:28:46Z

About the calculations etc, I would reccomend checking out and reusing our ScrollableLoaderBuilder widget in some way @mikolaj-jalocha @BombardierBulge

What's the status on the PR? Did you check out the ScrollableLoaderBuilder in the codebase?

Unfortunately no, but I'll check it soon in free time.

simon-the-shark · 2024-12-06T23:03:17Z

What's the status here?

mikolaj-jalocha

Final touches ;)

lib/features/sks-menu/presentation/sks_menu_screen.dart

mikolaj-jalocha · 2024-12-08T21:09:46Z

lib/features/sks-menu/presentation/widgets/sks_menu_tiles.dart

@@ -74,3 +75,41 @@ class SksMenuDishDetailsTile extends StatelessWidget {
    );
  }
 }
+
+class SksMenuTilesLoading extends StatelessWidget {


This class could be private and moved to sks_menu_view_loading

mikolaj-jalocha · 2024-12-08T21:10:00Z

lib/features/sks-menu/presentation/widgets/sks_menu_header.dart

@@ -49,3 +51,21 @@ class SksMenuHeader extends StatelessWidget {
    );
  }
 }
+
+class SksMenuHeaderLoading extends StatelessWidget {


This class could be private and moved to sks_menu_view_loading

mikolaj-jalocha · 2024-12-08T21:11:27Z

lib/features/sks-menu/presentation/widgets/sks_menu_view_loading.dart

+  }
+}
+
+class _SksMenuTitleLoadingPaddings extends StatelessWidget {


I don't like the name here. We don't use such convention anywhere else. Probably better to change it to SksMenuTileLoading and merge with existing widget of that name

mikolaj-jalocha

Please see the comments

simon-the-shark · 2024-12-08T23:25:22Z

replaced random animation loading indicator's with shimmer loading animation

look preview

I must say, that the visual effect is quite nice :)

mikolaj-jalocha

EXCELLENT CODE

LGTM 🚀🚀🚀🚀

mikolaj-jalocha and others added 6 commits November 12, 2024 09:01

Add padding to all elements if there is safe space causes by notch et…

ebf6869

…c. (#414) Co-authored-by: Rafal Rejek <[email protected]>

fix(map-view): update map_view_config.dart - Use preferred tile.opens…

73eb38e

…treetmap.org URL (#417) See openstreetmap/operations#737

add shimmer loading screen for SKS Menu

ef8e97c

add loading screen for SKS Menu

1fe2fca

simon-the-shark assigned BombardierBulge Nov 24, 2024

simon-the-shark added the enhancement New feature or request label Nov 24, 2024

simon-the-shark added this to the v1.2.0 - Mr. Shark, We Have to Cook milestone Nov 24, 2024

simon-the-shark linked an issue Nov 24, 2024 that may be closed by this pull request

feat/ add loading screen for SKS Menu #396

Closed

simon-the-shark reviewed Nov 24, 2024

View reviewed changes

lib/features/sks-menu/presentation/widgets/sks_menu_view_loading.dart Outdated Show resolved Hide resolved

simon-the-shark force-pushed the SKS_Menu_Loading_Screen branch 2 times, most recently from d1b97ce to 1fe2fca Compare November 29, 2024 17:08

BombardierBulge added 2 commits November 30, 2024 00:12

fix for SKS Menu loading screen

0a99fb0

fix for SKS Menu loading screen

15f17fa

BombardierBulge requested review from mikolaj-jalocha and tomasz-trela and removed request for tomasz-trela November 29, 2024 23:56

mikolaj-jalocha requested changes Nov 30, 2024

View reviewed changes

mikolaj-jalocha requested review from tomasz-trela and simon-the-shark November 30, 2024 13:13

simon-the-shark reviewed Nov 30, 2024

View reviewed changes

tomasz-trela and others added 5 commits November 30, 2024 19:40

feat: add home screen nav actions (#430)

95a35a6

fix: adapt to new format from api & fix old date shown despite menu b…

46f3d82

…eing checked recently

fix: fix sorting order on sks menu screen to resembles one shown on s…

a514fe7

…ks website & adapt for new data format

fix: update translation so that it resembles one shown at sks menu we…

26a5859

…bsite

simon-the-shark and others added 14 commits November 30, 2024 19:40

fix(bottom-nav-bar): rollback the guide icon

257b04e

docs: add more insight on the sks url

e309efa

feat: move sks people indicator

90e1bcb

fix: correct pop view app bar buttons' titles

2f1600f

chore: bump build

a656a76

feat: implement review request open store (#436)

4bed94a

navigation_tab_view.dart: add revirew openStoreListing behavior to review button

refactor: app store rating service (#437)

45a73d2

fix: licence dialog small screen #355 (#439)

ffe9c55

* Add Wrap * Fix translation * Fix problem with Dialog on small screens --------- Co-authored-by: Rafal Rejek <[email protected]>

docs: change github handbook link (#441)

10ce488

docs: add link to docs (#447)

bc9cda5

fix(science-clubs): shadows on apply filter button (#446)

402eba4

* /fix fix shadows on filter's screen * /fix fix shadows on filter's screen

Merge branch 'main' of https://github.com/Solvro/mobile-topwr

13c82d8

BombardierBulge added 3 commits December 8, 2024 21:30

/fix shimmer loading final form

5dd25a7

/fix shimmer loading final form

848e896

/fix shimmer loading final form

cfce4ba

mikolaj-jalocha self-requested a review December 8, 2024 21:04

mikolaj-jalocha requested changes Dec 8, 2024

View reviewed changes

BombardierBulge requested a review from mikolaj-jalocha December 8, 2024 21:51

mikolaj-jalocha requested changes Dec 8, 2024

View reviewed changes

/fix shimmer loading final form

9d8468a

BombardierBulge requested a review from mikolaj-jalocha December 9, 2024 19:51

mikolaj-jalocha approved these changes Dec 9, 2024

View reviewed changes

mikolaj-jalocha merged commit ea39e2b into main Dec 9, 2024
2 checks passed

mikolaj-jalocha deleted the SKS_Menu_Loading_Screen branch December 9, 2024 20:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/ add loading screen for SKS Menu #427

feat/ add loading screen for SKS Menu #427

BombardierBulge commented Nov 24, 2024 •

edited

Loading

mikolaj-jalocha commented Nov 24, 2024 •

edited

Loading

tomasz-trela commented Nov 24, 2024 •

edited

Loading

mikolaj-jalocha left a comment

mikolaj-jalocha Nov 30, 2024

mikolaj-jalocha Dec 8, 2024

mikolaj-jalocha Nov 30, 2024

mikolaj-jalocha Dec 8, 2024

BombardierBulge Dec 9, 2024 •

edited

Loading

mikolaj-jalocha Dec 9, 2024

mikolaj-jalocha Dec 9, 2024

mikolaj-jalocha Nov 30, 2024

mikolaj-jalocha Nov 30, 2024

BombardierBulge Nov 30, 2024

mikolaj-jalocha Nov 30, 2024

simon-the-shark left a comment

simon-the-shark commented Dec 2, 2024

BombardierBulge commented Dec 2, 2024

simon-the-shark commented Dec 6, 2024

mikolaj-jalocha left a comment

mikolaj-jalocha Dec 8, 2024

mikolaj-jalocha Dec 8, 2024

mikolaj-jalocha Dec 8, 2024

mikolaj-jalocha left a comment

simon-the-shark commented Dec 8, 2024

mikolaj-jalocha left a comment

feat/ add loading screen for SKS Menu #427

feat/ add loading screen for SKS Menu #427

Conversation

BombardierBulge commented Nov 24, 2024 • edited Loading

mikolaj-jalocha commented Nov 24, 2024 • edited Loading

tomasz-trela commented Nov 24, 2024 • edited Loading

mikolaj-jalocha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BombardierBulge Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simon-the-shark left a comment

Choose a reason for hiding this comment

simon-the-shark commented Dec 2, 2024

BombardierBulge commented Dec 2, 2024

simon-the-shark commented Dec 6, 2024

mikolaj-jalocha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikolaj-jalocha left a comment

Choose a reason for hiding this comment

simon-the-shark commented Dec 8, 2024

mikolaj-jalocha left a comment

Choose a reason for hiding this comment

BombardierBulge commented Nov 24, 2024 •

edited

Loading

mikolaj-jalocha commented Nov 24, 2024 •

edited

Loading

tomasz-trela commented Nov 24, 2024 •

edited

Loading

BombardierBulge Dec 9, 2024 •

edited

Loading