Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add linter #116

Merged
merged 8 commits into from
Jul 26, 2024
Merged

Feat/add linter #116

merged 8 commits into from
Jul 26, 2024

Conversation

simon-the-shark
Copy link
Member

@simon-the-shark simon-the-shark commented Jul 25, 2024 •
edited
Loading

  • set up total_lints package that turns on all linter rules by default
  • adjust just a few rules (personal prefs) - we can talk about some of the choices
  • apply the fixes and resolve linter issues
  • set up gh workflows that check on linter and formatting
  • README note

I would give it a try, we can adjust some rules etc if will cause any problems or inconveniences. Tell me what you think

@simon-the-shark simon-the-shark self-assigned this Jul 25, 2024
@simon-the-shark simon-the-shark force-pushed the feat/linter branch 3 times, most recently from aaeb0fb to 99ab12a Compare July 25, 2024 21:50
mikolaj-jalocha
mikolaj-jalocha approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! We should have done this since day 1 of the project. I totally agree with every lint. It make the code look a lot better :-)

README.md
@@ -144,6 +144,23 @@ fvm flutter run
3. Api helper module instructions: https://github.com/Solvro/topwr-mobile/tree/main/lib/api_base
4. We use `flutter_gen` for generating asset paths: https://pub.dev/packages/flutter_gen

# Before you push a commit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful actually!

analysis_options.yaml
# avoid_print: false # Uncomment to disable the `avoid_print` rule
# prefer_single_quotes: true # Uncomment to enable the `prefer_single_quotes` rule
prefer_single_quotes: false
prefer_double_quotes: true # I hate single quotes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me to! Since I started with Flutter always wondered why not be specific XD

@simon-the-shark simon-the-shark merged commit 9592d1a into main Jul 26, 2024
2 checks passed
@simon-the-shark simon-the-shark deleted the feat/linter branch July 26, 2024 13:44
simon-the-shark added a commit that referenced this pull request Jul 26, 2024
@simon-the-shark
merge: pull request #116 from Solvro/feat/linter
189eee0 
Feat/add linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikolaj-jalocha mikolaj-jalocha mikolaj-jalocha approved these changes

Assignees

@simon-the-shark simon-the-shark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-the-shark @mikolaj-jalocha