Skip to content

Commit

Permalink
repaired code to pass gh actions checks
Browse files Browse the repository at this point in the history
  • Loading branch information
jakubbaldyga committed Dec 13, 2024
1 parent d22f22e commit 3b7418c
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import "../../../../utils/context_extensions.dart";
import "../../../../utils/determine_contact_icon.dart";
import "../../../../widgets/detail_views/contact_section.dart";
import "../../../../widgets/detail_views/detail_view_app_bar.dart";
import "../../../../widgets/my_cached_image.dart";
import "../../../../widgets/my_error_widget.dart";
import "../../../../widgets/zoomable_optimized_directus_image.dart";
import "../data/models/digital_guide_response_extended.dart";
Expand Down Expand Up @@ -56,9 +55,9 @@ class _DigitalGuideView extends ConsumerWidget {
final widgets1 = [
const SizedBox(height: DetailViewsConfig.heightImage),
SizedBox(
height: 254,
height: DetailViewsConfig.heightImage,
child: ZoomableOptimizedDirectusImage(
digitalGuideResponseExtended.imageUrl,
digitalGuideResponseExtended.imageUrl,
),
),
HeadlinesSection(
Expand Down
1 change: 0 additions & 1 deletion lib/features/guide_detail_view/guide_detail_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import "../../widgets/loading_widgets/simple_previews/preview_text_prototype.dar
import "../../widgets/my_error_widget.dart";
import "../../widgets/my_expansion_tile.dart";
import "../../widgets/my_html_widget.dart";
import "../../widgets/optimized_directus_image.dart";
import "../../widgets/zoomable_optimized_directus_image.dart";
import "repository/guide_detail_view_repository.dart";
import "utils/get_the_latest_date.dart";
Expand Down
2 changes: 0 additions & 2 deletions lib/widgets/detail_views/sliver_header_section.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import "dart:math";
import "package:flutter/material.dart";

import "../../config/ui_config.dart";
import "../optimized_directus_image.dart";
import "../zoomable_optimized_directus_image.dart";
import "sliver_logo.dart";

Expand Down Expand Up @@ -57,7 +56,6 @@ class SliverHeaderSection extends SliverPersistentHeaderDelegate {
child: ZoomableOptimizedDirectusImage(backgroundImageUrl),
),
),

SliverLogo(
scaleFactor: scaleFactor,
activeGradient: activeGradient,
Expand Down
4 changes: 1 addition & 3 deletions lib/widgets/detail_views/sliver_logo.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import "package:flutter/material.dart";

import "../optimized_directus_image.dart";
import "../zoomable_optimized_directus_image.dart";

class SliverLogo extends StatelessWidget {
Expand Down Expand Up @@ -47,7 +46,7 @@ class SliverLogo extends StatelessWidget {
fit: BoxFit.scaleDown,
child: SizedBox.square(
dimension: logoSize * scaleFactor,
child: ZoomableOptimizedDirectusImage(
child: ZoomableOptimizedDirectusImage(
logoDirectusUrl,
boxFit: boxfit,
noShimmeringLoading: noShimmeringLoading,
Expand All @@ -62,4 +61,3 @@ class SliverLogo extends StatelessWidget {
);
}
}

21 changes: 8 additions & 13 deletions lib/widgets/zoomable_optimized_directus_image.dart
Original file line number Diff line number Diff line change
@@ -1,18 +1,14 @@
import "dart:ui";

import 'package:flutter/material.dart';
import "package:flutter/material.dart";
import "../theme/colors.dart";
import "optimized_directus_image.dart";


class ZoomableOptimizedDirectusImage extends StatelessWidget {

const ZoomableOptimizedDirectusImage(
this.imageUrl, {
super.key,
this.noShimmeringLoading = false,
this.boxFit = BoxFit.cover,
});
this.imageUrl, {
super.key,
this.noShimmeringLoading = false,
this.boxFit = BoxFit.cover,
});

final String? imageUrl;
final bool noShimmeringLoading;
Expand All @@ -35,8 +31,7 @@ class ZoomableOptimizedDirectusImage extends StatelessWidget {
Future<void> _showFullScreenImage(BuildContext context) async {
await Navigator.of(context).push(
MaterialPageRoute(
builder: (newContext) =>
Scaffold(
builder: (newContext) => Scaffold(
backgroundColor: ColorsConsts.greyLight,
body: GestureDetector(
onTap: () {
Expand All @@ -56,4 +51,4 @@ class ZoomableOptimizedDirectusImage extends StatelessWidget {
),
);
}
}
}

0 comments on commit 3b7418c

Please sign in to comment.