Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json fix? #378

Closed
wants to merge 5 commits into from
Closed

package.json fix? #378

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e296dc3
Update README.md
chunt007 Mar 16, 2023
f979441
Merge branch 'SolidOS:main' into main
chunt007 Jan 13, 2024
ccaad8f
Update package.json
chunt007 Jan 13, 2024
cbd50eb
Add files via upload
chunt007 Aug 26, 2024
bad7022
Add files via upload
chunt007 Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,7 @@ Here, just to show how it works, are how some RDF Classes map onto panes. Anythi
contacts (A VCARD Address Book, Group, Individual, Organization) can be handled by the one contact
pane. Any other pane which wants to deal with contacts can just use the pane within its own user interface.

If you have trouble seeing syntax highlighting for SPARQL, Turtle, TriG, N-Triples, N-Quads, etc...
Try installing an extension! For VSCode, there are many, but a great one is RDFox Syntax Highlighting.
Comment on lines +80 to +81
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have trouble seeing syntax highlighting for SPARQL, Turtle, TriG, N-Triples, N-Quads, etc...
Try installing an extension! For VSCode, there are many, but a great one is RDFox Syntax Highlighting.
If you have trouble seeing syntax highlighting for SPARQL, Turtle, TriG, N-Triples, N-Quads, etc.,
try installing an extension! For VSCode, there are many; one that we've used is
[RDFox Syntax Highlighting](https://marketplace.visualstudio.com/items?itemName=rdfox.rdfox-rdf).


![Mapping many classes on the L to panes on the R](https://solidos.github.io/solid-panes/doc/images/panes-for-classes.svg)
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"build-lib": "npm run build-form && babel src -d lib --source-maps --extensions '.ts,.js'",
"build-dev": "webpack --progress --mode=development",
"build-types": "tsc --emitDeclarationOnly",
"build-version": "./timestamp.sh > src/versionInfo.ts && eslint 'src/versionInfo.ts' --fix",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces whatever the build-version script did before by calling timestamp.sh with just a call to eslint. Does not seem right to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure as to why VSCode throws off that error, but in the mean time, perhaps we could use it as a cautionary suggestion to Windows 10 users? If it doesn't seem right, then maybe it is not. Should the suggestion instead go the readme?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the dev setup seems not to be Windows compatible. At least the timestamp.sh would need to change if we want to make the build run under windows. There might be more changes needed. Under Windows you could try using WSL.

"build-version": "eslint --fix",
"watch": "npm run build-version && babel src -d lib --source-maps --extensions '.ts,.js' --watch",
"clean": "rm -rf dist lib",
"lint": "eslint 'src/**/*.js' 'src/**/*.ts'",
Expand Down
Loading