-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editProfile pane #55
Conversation
Not sure why there is a CI test using node 14.x
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you meant to toggle between the profile-pane and edit profile pane seamlessly? solid panes repo lets me toggle when I load the panes individually. When I click on the edit button here, it attempts to load the pane but stays on the main profile.
My friends list is also gone. I have noticed that under languages, it now says Fr and En, instead of French and English.
This is on a fresh profile-pane install with the pull requests added.
"Are you meant to toggle between the profile-pane and edit profile pane seamlessly?" -- no that workflow with the edit button is just a placeholder. This PR is just about refactoring the edit button code to be in the same repo. Not supposed to be any functional changes. The "fr" for "french" suggests it is missing some labels. |
Moved from solid-panes.