Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editProfile pane #55

Merged
merged 20 commits into from
Oct 17, 2024
Merged

Add editProfile pane #55

merged 20 commits into from
Oct 17, 2024

Conversation

timbl
Copy link
Contributor

@timbl timbl commented Sep 16, 2024

Moved from solid-panes.

@timbl
Copy link
Contributor Author

timbl commented Oct 14, 2024

Not sure why there is a CI test using node 14.x
when the .github/workflows/ci.yml says

  node-version: [ 16.x, 18.x ]

Copy link
Contributor

@chunt007 chunt007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you meant to toggle between the profile-pane and edit profile pane seamlessly? solid panes repo lets me toggle when I load the panes individually. When I click on the edit button here, it attempts to load the pane but stays on the main profile.

1
2

My friends list is also gone. I have noticed that under languages, it now says Fr and En, instead of French and English.

This is on a fresh profile-pane install with the pull requests added.

@timbl
Copy link
Contributor Author

timbl commented Oct 16, 2024

"Are you meant to toggle between the profile-pane and edit profile pane seamlessly?" -- no that workflow with the edit button is just a placeholder. This PR is just about refactoring the edit button code to be in the same repo. Not supposed to be any functional changes.

The "fr" for "french" suggests it is missing some labels.

@timbl
Copy link
Contributor Author

timbl commented Oct 17, 2024

image

@timbl timbl merged commit 5bc3363 into main Oct 17, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants