DATAGO-78976: Quality | EMA metrics for number of ongoing jobs + health check metrics #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment-agent into crushton/DATAGO-78976_cmea_metrics
CameronRushton
had a problem deploying
to
build_pr
GitHub Actions
Failure
CameronRushton
had a problem deploying
to
build_pr
GitHub Actions
Failure
CameronRushton
had a problem deploying
to
build_pr
GitHub Actions
Failure
CameronRushton
temporarily deployed
to
build_pr
GitHub Actions
Inactive
…ve a better place to set and check fields for null values
CameronRushton
had a problem deploying
to
build_pr
GitHub Actions
Failure
CameronRushton
temporarily deployed
to
build_pr
GitHub Actions
Inactive
CameronRushton
changed the title
CameronRushton
requested review from
mynecker,
moodiRealist and
rudraneel-chakraborty
Comment on lines
+76
to
83
| ScanTypeRepository scanTypeRepository, | ||
| ScanStatusRepository scanStatusRepository, | ||
| ScanRouteService scanRouteService, | ||
| RouteService routeService, | ||
| ProducerTemplate producerTemplate, | ||
| IDGenerator idGenerator, | ||
| MeterRegistry meterRegistry) { | ||
| this.repository = repository; |
rudraneel-chakraborty
approved these changes
Aug 30, 2024
CameronRushton
temporarily deployed
to
build_pr
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Add metrics for scan, config push, and heartbeat where it is easy to do, so that POs and devs can see how many requests are going through the system and if the EMA is connected to the EVMR via heartbeat.
How was this change implemented?
Adding counters on events sent and received for CEMA scans and config push. I'll say that again, it's cloud only.
Added a gauge for if the CEMA is connected to the EVMR. Returns a 1 if connected, 0 otherwise.
Added cycle time for config push since it was easy to do so. The request object exists the entire way until it gets converted into a response.
Scan is harder to implement because the initial request is lost in some mapping and async behaviour.
How was this change tested?
Deploying and running the CEMA for a scan and config push in ep-perf.
Is there anything the reviewers should focus on/be aware of?
None