DATAGO-80463: micrometer statsd log spam #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mynecker
changed the title
|
SonarQube Quality Gate
|
service/application/src/main/java/com/solace/maas/ep/event/management/agent/EMAApplication.java
Show resolved
Hide resolved
moodiRealist
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Fixing log spam of micrometers statsd exporter when
management.statsd.metrics.export.enabled: falseinenv.ymlis not provided.How was this change implemented?
Added SpringBoot default configuration in
EMAApplication.java(lowest precedence)How was this change tested?
In local development environment
created a Docker image
started EMA without any
management.micrometer.*configurations defined inenv.ymlcould not observer log spam anymore
started EMA with configuration
management.statsd.metrics.export.enabled: trueinenv.ymllog spam can be observed - as expected due to missing
statsdUDP listenerIs there anything the reviewers should focus on/be aware of?
nope