[DATAGO-80317] fix issues blocking standalone mode from executing. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is that we are running in standalone mode.
moodiRealist
changed the title
|
SonarQube Quality Gate
|
mynecker
reviewed
Jul 17, 2024
There was a problem hiding this comment.
@moodiRealist I added a second test to cover standalone mode, too
mynecker
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
LGTM and @moodiRealist please cross-check the added test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
To fix bugs when running the application in standalone mode and certain config values are not available.
How was this change implemented?
Made the existence of a troublesome bean optional.
Also update the default for
event-portal.gateway.messaging.standalonein conditionalExpressions to set to True.How was this change tested?
Updated tests, and manually created docker image, then ran scans from both standalone and connected mode. They both worked.
Connected:
Standalone:
Is there anything the reviewers should focus on/be aware of?
Nope.