DATAGO-64298: rotate command log files. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodiRealist
temporarily deployed
to
build_pr
GitHub Actions
Inactive
service/terraform-plugin/pom.xml
Outdated
Comment on lines
90
to
96
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| <version>2.10.1</version> | ||
| </dependency> | ||
| </dependencies> |
There was a problem hiding this comment.
☁️ I was wondering if adding another json processing library is needed. I think we already have jackson library available to ema, can we reuse that library?
moodiRealist
temporarily deployed
to
build_pr
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
To rotate command log files using logback functionality.
How was this change implemented?
updated logback-spring.xml and removed previous manual logging functionality.
How was this change tested?
Ran the code multiple times to see logs being rotated and eventually removed:
Is there anything the reviewers should focus on/be aware of?
Also added a new attribute
eventManagementIdto commandLogs message to satisfy a requirement