update the conditions to create beans based on eventPortal section #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmeldrum
approved these changes
Oct 27, 2023
|
SonarQube Quality Gate
|
mo-radwan1
deleted the
remove-event-portal-section-from-config-file-in-standalone-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Update the conditions to create the spring beans based on the existence of the
eventPortalsection in theapplication.ymlfileHow was this change implemented?
By providing default values for the
EventPortalPropertieswhen theeventPortaldoesn't exist in theapplication.ymlfile. Also, updating the conditions to instantiate classes based on the value ofstandaloneflag.How was this change tested?
Manually by starting the EMA using different configs in
application.ymlfile, e.g., with and withouteventPortalsection, then running scans in online and offline modesIs there anything the reviewers should focus on/be aware of?
N/A