add EMA version to heartbeat message #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2023 14:53
pwang1997
requested review from
helrac and
gregmeldrum
and removed request for
helrac
|
SonarQube Quality Gate
|
| @@ -52,7 +52,7 @@ public void ack() { | |||
|
|
|||
| @Test | |||
| public void testHeartbeatAgentMOPProtocol() { | |||
| HeartbeatMessage message = new HeartbeatMessage("runtimeId", "timestamp"); | |||
| HeartbeatMessage message = new HeartbeatMessage("runtimeId", "timestamp", "1.1.2"); | |||
There was a problem hiding this comment.
Since this change is not backwardCompatible, we should upversion ema on the minor version
moodiRealist
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Add EMA version to heartbeat message for debugging purposes.
How was this change implemented?
Add EMA version to heartbeat message.
How was this change tested?
Update test
Is there anything the reviewers should focus on/be aware of?
This change will be minor upversioned.