Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features: inline broker request-response, temporary queues, improved docs and examples and better testing #39

Merged
merged 20 commits into from
Sep 26, 2024

Conversation

efunneko
Copy link
Collaborator

The following comprehensive updates have been made to the Solace AI Event Connector repository, which includes code refactoring, enhancements, and expanded documentation.

Documentation

  1. README.md:

    • Moved the "Getting Started Quickly" section after the Overview.
  2. Advanced Component Features:

    • Added to describe advanced features available for custom components, such as Broker Request-Response, Cache Manager, and Timer Features.
  3. Component Documentation:

    • Detailed documentation has been added for aggregate, assembly, broker_input, error_input, and other components. This includes configuration details, input/output schema, and example configurations.
  4. Usage and Configuration:

    • Removed the previous usage.md.
    • Extended the main configuration file structure, specifying log/trace configurations, shared configurations, and detailed expression syntax.
    • invoke_keyword: Detailed invocation configurations using custom functions or invoke_functions.
  5. Custom Components:

    • Added custom_components.md discussing how to extend the functionality by creating custom components, providing required structure, methods, and advanced features.
  6. Guides:

    • Added a comprehensive guide on RAG (Retrieval-Augmented Generation), LLM models, and embeddings, leveraging OpenAI with ChromaDB via the Solace AI Connector.

Features and Enhancements

  1. Broker Request-Response:

    • Implemented in broker_request_response.py to handle both simple and streaming responses. Configurations are detailed in the documentation.
  2. Components Enhancements:

    • aggregate.py: Extended to include new configuration parameters, better handling and documentation.
    • assembly.py: New component added for assembling messages with specified configurations.
    • error_input.py and broker_input.py: Refactored and aligned with new configurations (e.g., input_selection instead of component_input).
  3. Transforms Enhancements:

    • Refined structured handling of evaluate_expression keyword with better documentation.
    • General refactor for better clarity and reusability, ensuring all transform functions are working as expected.
  4. Extensibility via Custom Components:

    • Provided detailed guidelines and examples on how to create scheduleable timer events, handle cache expiry, and perform request-response operations.

Examples

  1. New and Updated Examples:
    • Added examples to illustrate setups for OpenAI configurations, Request-Response flows, and more.
    • Examples directory (examples/llm) updated with detailed flow configurations using different AI/ML models and vector databases.

Testing

  1. Test Utilities:
    • Enhanced utils_for_test_files.py for better test handling with importing and message validation across flows.
    • Introduced new tests for request-response functionalities, aggregate, and iterate components.

Code Refactoring

  1. Imports and Path Handling:

    • Refactored import statements and path handling for modularity and clarity.
    • Enhanced error handling and logging throughout the project.
  2. Modularization and Clean Code:

    • Split and clean components and transform files for better maintainability.
    • Removed redundant storage implementations and debugging remnants.

cyrus2281 and others added 17 commits August 27, 2024 14:04
* Removed StorageManager

* Added examples for OpenAI, Bedrock, Anthropic, and VertexAI

* Updating old examples (1/2)

* Updating old examples (2/2)
* Added the assembly component

* Auto-generated documents

* Added type check

* Update the cache service expiry logic + Update the assembly component to use cache expiry for timeout

* Moved assembly to the correct place
* MoA example: Broadcast to multiple agents

* Added MoA event manager, added uuid invoke_function + test, updated auto-generated docs

* Added assembly layer to MoA example
…rce_expression (#29)

* Refactored component_input to input_selection

* Updated, added, and enhanced the documentation with new users in mind

* Refactored source_expression function to evaluate_expression (backward compatible)

* Added tips and tricks section + info and examples on custom modules

* tiny format update

* tiny update
* Added a RAG example for AI connector

* Added delete option to vectordb

* Changed id to ids
Fix the method to not trim the first entry if it is a "system" role
)

* chore: Refactor clear_history_but_keep_depth method to handle negative depth values

* chore: small change to how this is solved

* chore: one more try

* refactor: move utils_for_test_files.py to solace_ai_connector module

* refactor: removed the orginal utils_for_test_files.py

* refactor: update import statements in test files

* refactor: add sys.path.append("src") to test files

* refactor: standardize import order and sys.path.append in test files

* refactor: a bit more test infrastructure changes

* feat: allow component_module to accept module objects directly

* feat: add types module import to utils.py

* test: add static import and object config test

* refactor: update test_static_import_and_object_config to use create_test_flows

* refactor: Improve test structure and remove duplicate test case

* fix: remove duplicate import of yaml module

* refactor: Modify test config to use dict instead of YAML string

* refactor: convert config_yaml from string to dictionary

* refactor: update static import test to use pass_through component

* test: Add delay component message passing test

* feat: add test for delay component message processing

* feat: Added a new test function (test_one_component) to make it very easy to just run some quick tests on a single input -> expected output tests on a single component

* feat: added input_transforms to the test_one_component so that input transforms can be tested with it

* chore: a bit of cleanup and new tests for test_one_component

* chore: rename test_one_component because it was being picked up as a test by the pytest scanner

* fix: fixed a typo
* Added guide for RAG

* update wording
…u can test situations where you don't expect any output (#34)
…nse ability for components (#42)

* feat: add request_response_controller.py

* feat: implement RequestResponseFlowManager and RequestResponseController classes

* style: format code with black and improve readability

* feat: implement RequestResponseController for flow-based request-response handling

* feat: implement RequestResponseController for handling request-response patterns

* fix: import SolaceAiConnector for type checking

* refactor: restructure Flow class and improve code organization

* feat: implement multiple named RequestResponseControllers per component

* refactor: initialize request-response controllers in ComponentBase

* test: add request_response_controller functionality tests

* feat: finished implementation and added some tests

* refactor: rename RequestResponseController to RequestResponseFlowController

* refactor: rename RequestResponseController to RequestResponseFlowController

* refactor: some name changes

* fix: update test function names for RequestResponseFlowController

* refactor: more name changes

* Ed/req_resp_examples_and_fixes (#41)

* feat: Added a request_response_flow example and fixed a few issues along the way

* feat: Reworked the broker_request_response built-in ability of components to be simpler. Instead of having to have a defined flow and then name that flow, it will automatically create a flow with a single broker_request_response component in it. Now there is a straightforward interating function call to allow components to issue a request and get streaming or non-streaming responses from that flow.

* chore: fix the request_response example and remove the old one

* docs: add broker request-response configuration

* docs: added advanced_component_features.md

* docs: add broker request-response configuration details

* docs: add payload encoding and format to broker config

* docs: add cache service and timer manager to advanced_component_features.md

* docs: add configuration requirement for broker request-response

* docs: update broker request-response section with configuration info

* docs: a bit more detail about do_broker_request_response

* docs: add link to advanced features page in table of contents

* docs: add link to advanced features page

* docs: reorder table of contents in index.md

* docs: add custom components documentation

* docs: Remove advanced component features from table of contents

* docs: clean up a double inclusion of the same section

* docs: small example change

* chore: remove dead code

* chore: add some extra comments to explain some test code

* docs: Update description of STDIN input component

Update the description of the STDIN input component to clarify that it waits for its output message to be acknowledged before prompting for the next input. This change is made in the `stdin_input.py` file.

* chore: add is_broker_request_response_enabled method

* chore: Some changes after review
@efunneko efunneko requested a review from cyrus2281 September 23, 2024 15:37
@efunneko efunneko merged commit 7cf742d into SolaceLabs:main Sep 26, 2024
2 checks passed
cyrus2281 added a commit that referenced this pull request Dec 3, 2024
…ved docs and examples and better testing (#39)

* Examples Update + Code Refactor (#25)

* Removed StorageManager

* Added examples for OpenAI, Bedrock, Anthropic, and VertexAI

* Updating old examples (1/2)

* Updating old examples (2/2)

* Added support for temporary queue + UUID queue name (#26)

* Add assembly component and auto-generated documents (#27)

* Added the assembly component

* Auto-generated documents

* Added type check

* Update the cache service expiry logic + Update the assembly component to use cache expiry for timeout

* Moved assembly to the correct place

* Added MoA Example + UUID Invoke Function (#28)

* MoA example: Broadcast to multiple agents

* Added MoA event manager, added uuid invoke_function + test, updated auto-generated docs

* Added assembly layer to MoA example

* Update documentation for new users + Refactored component_input & source_expression (#29)

* Refactored component_input to input_selection

* Updated, added, and enhanced the documentation with new users in mind

* Refactored source_expression function to evaluate_expression (backward compatible)

* Added tips and tricks section + info and examples on custom modules

* tiny format update

* tiny update

* Fixed solace disconnection issues on shutting down (#30)

* Add RAG example for AI connector + delete action for vector index (#31)

* Added a RAG example for AI connector

* Added delete option to vectordb

* Changed id to ids

* chore: Refactor make_history_start_with_user_message method (#32)

Fix the method to not trim the first entry if it is a "system" role

* Keep history depth needs to be a positive integer and test refactor (#33)

* chore: Refactor clear_history_but_keep_depth method to handle negative depth values

* chore: small change to how this is solved

* chore: one more try

* refactor: move utils_for_test_files.py to solace_ai_connector module

* refactor: removed the orginal utils_for_test_files.py

* refactor: update import statements in test files

* refactor: add sys.path.append("src") to test files

* refactor: standardize import order and sys.path.append in test files

* refactor: a bit more test infrastructure changes

* feat: allow component_module to accept module objects directly

* feat: add types module import to utils.py

* test: add static import and object config test

* refactor: update test_static_import_and_object_config to use create_test_flows

* refactor: Improve test structure and remove duplicate test case

* fix: remove duplicate import of yaml module

* refactor: Modify test config to use dict instead of YAML string

* refactor: convert config_yaml from string to dictionary

* refactor: update static import test to use pass_through component

* test: Add delay component message passing test

* feat: add test for delay component message processing

* feat: Added a new test function (test_one_component) to make it very easy to just run some quick tests on a single input -> expected output tests on a single component

* feat: added input_transforms to the test_one_component so that input transforms can be tested with it

* chore: a bit of cleanup and new tests for test_one_component

* chore: rename test_one_component because it was being picked up as a test by the pytest scanner

* fix: fixed a typo

* Fix for anthropic example (#35)

* Updating version dependency (#37)

* Fixed url and file name in getting started (#38)

* Add guide for RAG (#39)

* Added guide for RAG

* update wording

* Added link to other docs from RAG guide (#40)

* chore: added a timeout setting for running component tests so that you can test situations where you don't expect any output (#34)

* AI-124: Add a feature to provide simple blocking broker request/response ability for components (#42)

* feat: add request_response_controller.py

* feat: implement RequestResponseFlowManager and RequestResponseController classes

* style: format code with black and improve readability

* feat: implement RequestResponseController for flow-based request-response handling

* feat: implement RequestResponseController for handling request-response patterns

* fix: import SolaceAiConnector for type checking

* refactor: restructure Flow class and improve code organization

* feat: implement multiple named RequestResponseControllers per component

* refactor: initialize request-response controllers in ComponentBase

* test: add request_response_controller functionality tests

* feat: finished implementation and added some tests

* refactor: rename RequestResponseController to RequestResponseFlowController

* refactor: rename RequestResponseController to RequestResponseFlowController

* refactor: some name changes

* fix: update test function names for RequestResponseFlowController

* refactor: more name changes

* Ed/req_resp_examples_and_fixes (#41)

* feat: Added a request_response_flow example and fixed a few issues along the way

* feat: Reworked the broker_request_response built-in ability of components to be simpler. Instead of having to have a defined flow and then name that flow, it will automatically create a flow with a single broker_request_response component in it. Now there is a straightforward interating function call to allow components to issue a request and get streaming or non-streaming responses from that flow.

* chore: fix the request_response example and remove the old one

* docs: add broker request-response configuration

* docs: added advanced_component_features.md

* docs: add broker request-response configuration details

* docs: add payload encoding and format to broker config

* docs: add cache service and timer manager to advanced_component_features.md

* docs: add configuration requirement for broker request-response

* docs: update broker request-response section with configuration info

* docs: a bit more detail about do_broker_request_response

* docs: add link to advanced features page in table of contents

* docs: add link to advanced features page

* docs: reorder table of contents in index.md

* docs: add custom components documentation

* docs: Remove advanced component features from table of contents

* docs: clean up a double inclusion of the same section

* docs: small example change

* chore: remove dead code

* chore: add some extra comments to explain some test code

* docs: Update description of STDIN input component

Update the description of the STDIN input component to clarify that it waits for its output message to be acknowledged before prompting for the next input. This change is made in the `stdin_input.py` file.

* chore: add is_broker_request_response_enabled method

* chore: Some changes after review

* feat: AI-129: add ability to specify a default value for a an environment variable in a .yaml config file (#43)

* DATAGO-85484 Bump min python version

---------

Co-authored-by: Cyrus Mobini <[email protected]>
Co-authored-by: Art Morozov <[email protected]>
Co-authored-by: Art Morozov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants