Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOL-103114 & SOL-103115 Update otel versions for jcsmp/jms #260

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

Mrc0113
Copy link
Collaborator

@Mrc0113 Mrc0113 commented Oct 6, 2023

This PR fixing the code must be reviewed and merged prior to merging this PR.

@Mrc0113 Mrc0113 requested a review from TamimiGitHub October 6, 2023 16:45
@solacecommunity-bot
Copy link
Collaborator

Thanks for opening up a PR and contributing to our open source codelabs!

Review process Guidelines

Once the PR is opened, tag at least one Technical Reviewer

Technical Reviewer Responsibilities

  • Dry-run technical steps
  • Review technical positioning/messaging
  • Point out typos and potential formatting issues
  • Technical Reviewer(s): "Approve" or "Request Changes" by navigating to the Files changed tab and click on the "Review Changes" drop down
    Review Changes button

Post Technical Review

A member of the Developer Advocate Team will review overall structure and merge into master which will push it to production

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

TamimiGitHub
TamimiGitHub previously approved these changes Oct 6, 2023
Copy link
Member

@TamimiGitHub TamimiGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TamimiGitHub TamimiGitHub merged commit 47e5f98 into master Oct 6, 2023
3 checks passed
@TamimiGitHub TamimiGitHub deleted the sol-103114 branch May 21, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants