Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codelab sap aem int #259

Closed
wants to merge 20 commits into from
Closed

Conversation

bradcaldwell88
Copy link
Collaborator

No description provided.

@solacecommunity-bot
Copy link
Collaborator

Thanks for opening up a PR and contributing to our open source codelabs!

Review process Guidelines

Once the PR is opened, tag at least one Technical Reviewer

Technical Reviewer Responsibilities

  • Dry-run technical steps
  • Review technical positioning/messaging
  • Point out typos and potential formatting issues
  • Technical Reviewer(s): "Approve" or "Request Changes" by navigating to the Files changed tab and click on the "Review Changes" drop down
    Review Changes button

Post Technical Review

A member of the Developer Advocate Team will review overall structure and merge into master which will push it to production

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

@TamimiGitHub
Copy link
Member

Two quick comments:

  1. Dont forget to ./export.sh and add all the html generated files in this PR for preview generation
  2. Dont include .project IDE specific files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants