v1.2 App Store Release #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reworking classes and adding repositories * Update repository * ViewModelController and Repos are working * Lots of additions and reworking of views - Fixes for repositories - 60fps scrolling - Fixed html encodings - Started switching out some view controllers for cleaner versions * Fixed FilterObject * Fix recommened api request * Added remoteCommandManager toggle change playback position Fix for this issue: #25 * Build for beta and fixed CollectionView Layout scaling * fixed audio view label * Clean up clean up Fixed User Model Fixed repos and search controller Deleted a lot of old code * Removed and cleaned up code/files Also fixed search controller since there was an issue with calling the api too many times after we returned 0 results * Reworking classes and adding repositories * Update repository * ViewModelController and Repos are working * Lots of additions and reworking of views - Fixes for repositories - 60fps scrolling - Fixed html encodings - Started switching out some view controllers for cleaner versions * Fixed FilterObject * Fix recommened api request * Added remoteCommandManager toggle change playback position Fix for this issue: #25 * Build for beta and fixed CollectionView Layout scaling * fixed audio view label * Clean up clean up Fixed User Model Fixed repos and search controller Deleted a lot of old code * Removed and cleaned up code/files Also fixed search controller since there was an issue with calling the api too many times after we returned 0 results * After rebase with a few fixes * Remove comment * Review Fixes * Removed Kingfisher in favor for SDWebImage This looks to fix a memory issue with Kingfisher caching all the images and using a lot of memory. * Fixed models and voting on header view * Forgot to push this pod update * Fixed tab bar not selecting first index on load. Fixed Image caching * Fix skeletonCollectionView stopping when leaving a view * 1.2 beta build 11
themisterholliday
added a commit
that referenced
this pull request
Nov 5, 2017
* v1.2 App Store Release (#39) * Refactor To MVVM (#29) * Reworking classes and adding repositories * Update repository * ViewModelController and Repos are working * Lots of additions and reworking of views - Fixes for repositories - 60fps scrolling - Fixed html encodings - Started switching out some view controllers for cleaner versions * Fixed FilterObject * Fix recommened api request * Added remoteCommandManager toggle change playback position Fix for this issue: #25 * Build for beta and fixed CollectionView Layout scaling * fixed audio view label * Clean up clean up Fixed User Model Fixed repos and search controller Deleted a lot of old code * Removed and cleaned up code/files Also fixed search controller since there was an issue with calling the api too many times after we returned 0 results * Reworking classes and adding repositories * Update repository * ViewModelController and Repos are working * Lots of additions and reworking of views - Fixes for repositories - 60fps scrolling - Fixed html encodings - Started switching out some view controllers for cleaner versions * Fixed FilterObject * Fix recommened api request * Added remoteCommandManager toggle change playback position Fix for this issue: #25 * Build for beta and fixed CollectionView Layout scaling * fixed audio view label * Clean up clean up Fixed User Model Fixed repos and search controller Deleted a lot of old code * Removed and cleaned up code/files Also fixed search controller since there was an issue with calling the api too many times after we returned 0 results * After rebase with a few fixes * Remove comment * Review Fixes * Removed Kingfisher in favor for SDWebImage This looks to fix a memory issue with Kingfisher caching all the images and using a lot of memory. * Fixed models and voting on header view * Forgot to push this pod update * Fixed tab bar not selecting first index on load. Fixed Image caching * Fix skeletonCollectionView stopping when leaving a view * 1.2 beta build 11 * v1.2 build 12 * v1.2 build 13 * updated podfile/fix for responsive ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.