Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around blizzard delves event bug #43

Closed
ynazar1 opened this issue Oct 1, 2024 · 1 comment
Closed

Work around blizzard delves event bug #43

ynazar1 opened this issue Oct 1, 2024 · 1 comment

Comments

@ynazar1
Copy link
Contributor

ynazar1 commented Oct 1, 2024

In 11.0.2 while in delves the event GROUP_ROSTER_UPDATE constantly triggers causing addon to recalculate buffs

https://us.forums.blizzard.com/en/wow/t/an-event-called-grouprosterupdate-appears-to-be-constantly-firing/1940551

This causes constant stutter due to cost of redoing all the calls every second.
smartbuff.lua line 706 or so:

  if event == "ZONE_CHANGED_NEW_AREA" or event == "GROUP_ROSTER_UPDATE" then
    SMARTBUFF_SetTemplate()
  end
@ynazar1
Copy link
Contributor Author

ynazar1 commented Oct 1, 2024

Putting a workaround to get it to not spam template refresh during delves. I'm not super happy about this but this is kinda of a hack around a bug. This could have some unintended consequences if group changes during a scenario but those are rare edge cases i imagine.

  -- TODO: This is a blizzard bug workaround that spams GROUP_ROSTER_UPDATE during delves
  local name, instanceType, difficultyID, difficultyName, maxPlayers, dynamicDifficulty, isDynamic, instanceID, instanceGroupSize, LfgDungeonID =
  GetInstanceInfo()
  if event == "ZONE_CHANGED_NEW_AREA" or (event == "GROUP_ROSTER_UPDATE" and instanceType ~= "scenario") then
    SMARTBUFF_SetTemplate()
  end

@ynazar1 ynazar1 closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant