Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Paderborn not a valid option for university #21

Open
pmbittner opened this issue Mar 8, 2024 · 7 comments
Open

Build: Paderborn not a valid option for university #21

pmbittner opened this issue Mar 8, 2024 · 7 comments
Assignees
Labels
build documentation Improvements or additions to documentation question Further information is requested

Comments

@pmbittner
Copy link
Member

Hi all,

I followed the instructions for building the slides in the README.md to build the slides for Paderborn. When I run

make 01-introduction.tex university=paderborn

I get the message make: Nothing to be done for '01-introduction.tex'. but there is no pdf. I checked the makefile and it seems that the feature university does not yet allow the value paderborn.

Also, there are two other build scripts compile_ulm.sh and compile_paderborn.sh. These scripts are undocumented. Are they orthogonal to the makefile? If so, why are there two build systems? If not, when and how to use these scripts? Does make call them? Running

./compile_paderborn.sh

gives ERROR: is not a valid integer. Running

./compile_paderborn.sh 1

just prints 01-introduction and does nothing more.

So the problems are:

  • makefile does not support paderborn
  • compile_(ulm|paderborn).sh are undocumented and its unclear when and how to use them
@pmbittner pmbittner added documentation Improvements or additions to documentation question Further information is requested build labels Mar 8, 2024
@ekuiter
Copy link
Member

ekuiter commented Mar 8, 2024

Try make 01-introduction.pdf university=paderborn (file extension pdf, not tex). For me, this works, and make university=paderborn compiles them all. I updated the Makefile to include paderborn as an allowed value.

@ekuiter
Copy link
Member

ekuiter commented Mar 8, 2024

These scripts are undocumented. Yes, @skrieter wrote them, maybe he can explain. The Makefile does not call them, I have only ever used the Makefile and the documented commands in the README. (I am also not sure about the purpose of spl1.tex and spl2.tex. These currently cause the Makefile to stop with an error, but at this point all individual slides should have been compiled.)

@pmbittner
Copy link
Member Author

Try make 01-introduction.pdf university=paderborn (file extension pdf, not tex). For me, this works, and make university=paderborn compiles them all. I updated the Makefile to include paderborn as an allowed value.

Omg I am so dumb. :D Thanks for the hint and thanks for updating the makfile. It works as expected now. :)

@ekuiter
Copy link
Member

ekuiter commented Mar 8, 2024

this actually happens to me all the time, too ^^

@ekuiter
Copy link
Member

ekuiter commented Mar 8, 2024

FYI: There are currently two new padding bugs (#16, #17) due to the template update, which I will try to fix next week.

@tthuem
Copy link
Member

tthuem commented Mar 8, 2024

@skrieter Can you document how to use your compile scripts in the readme?

@ekuiter
Copy link
Member

ekuiter commented Mar 13, 2024

things to consider:

  • compile_paderborn.sh is redundant
  • the script has code clones
  • the script could reuse the makefile instead of calling LaTeX manually

I suspect it would be best to integrate it fully with the Makefile to avoid confusion. To do this, I would need more information on the script's purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants