Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self Assessment: Two Column Layout #281

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Self Assessment: Two Column Layout #281

merged 1 commit into from
Feb 19, 2019

Conversation

KevinChheang
Copy link
Collaborator

@KevinChheang KevinChheang commented Feb 17, 2019

Describe the changes in this Pull Request
Added breakpoint to grid column to response to different screen sizes.

What issue(s) does this Pull Request resolve?
Cards display 2 columns on large screen and 1 column on small screen.

Use any of these keywords followed by the issue number: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved #[issueNumber]

  1. Resolves Self Assessment: Two Column Layout #277
  2. Closes Self Assessment: Two Column Layout #277

@ghost ghost assigned KevinChheang Feb 17, 2019
@ghost ghost added the code review This PR is ready for code review label Feb 17, 2019
@khoadnguyen
Copy link
Contributor

khoadnguyen commented Feb 18, 2019

Looks good, let's pull it up in class and review the changes. One change, would you please reference the issues this resolves on your comment above? (I don't think it resolves issue #1).

@KevinChheang
Copy link
Collaborator Author

Looks good, let's pull it up in class and review the changes. One change, would you please reference the issues this resolves on your comment above? (I don't think it resolves issue #1).

Gotcha, I don't know why I put issue #1. Anyway, I fixed it.

@khoadnguyen
Copy link
Contributor

🌵

@khoadnguyen khoadnguyen merged commit caf03cf into dev Feb 19, 2019
@ghost ghost removed the code review This PR is ready for code review label Feb 19, 2019
@khoadnguyen khoadnguyen deleted the 277-self-assessment branch February 19, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self Assessment: Two Column Layout
2 participants