Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when loading gcode file twice #7217

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Fix crash when loading gcode file twice #7217

merged 2 commits into from
Oct 26, 2024

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Oct 24, 2024 •
edited
Loading

Reproduce:

  1. Get a gcode file
  2. Open Orca
  3. Drag the gcode file into Orca
  4. Drag the gcode file into Orca, again
  5. Crash
    gcode_crash

SoftFever
SoftFever approved these changes Oct 26, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@SoftFever SoftFever merged commit 2348928 into SoftFever:main Oct 26, 2024
15 checks passed
@Noisyfox Noisyfox deleted the bugfox/crash-gcode branch October 26, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noisyfox @SoftFever