Update BBL configs to include support for air filtration by default for X1, X1C, X1E, and P1S #6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoftFever
reviewed
Oct 7, 2024
| @@ -24,6 +24,7 @@ | |||
| "extruder_offset": [ | |||
| "0x2" | |||
| ], | |||
| "support_air_filtration": "1", | |||
There was a problem hiding this comment.
This is duplicated.
X1E already defined it
* Fix wipe tower issues with SEMM and ramming turned off * Purge tower last layer collision potential fix (for SEMM) * Revert "Purge tower last layer collision potential fix (for SEMM)" This reverts commit 9fc465c.
…lygon (SoftFever#6955) Fix issue that `z` is not properly set in some cases when clipping the polygon (SoftFever#6933) Apply the patch from https://sourceforge.net/p/polyclipping/bugs/160/
* Update OrcaSlicer_es.po
* Russian translation update The next russian translation update OrcaSlicer V2.1.1 Official Release. The work done to improve translation, corrected errors. Thx. * Russian translation update The next russian translation update OrcaSlicer v2.2.0-beta2. The work done to improve translation, corrected errors. Thx. * Russian translation update The next russian translation update OrcaSlicer V2.2.0-beta2 + 3 lines in text.js The work done to improve translation, corrected errors. Thx.
…oftFever#6952) * Qidi.json * Qidi.json * Qidi.json * new change new change
…th wipe tower extrusions.
… be changed after parsing get_last_z_from_gcode
*Some max speeds/accelerations changes for the 0.4 nozzle was left out as none of the other nozzles had these max speeds/accelerations
|
Uh I definitely screwed something up here... closing and recreating pull request |
SoftFever
added a commit
that referenced
this pull request
Oct 22, 2024
# Description Re-Creation of Pull Request #6964 with X1E changes pulled. OrcaSlicer includes exhaust fan settings for each filaments, however these settings do not take effect on Bambu Labs machines that include chamber temperature regulation fans.  Further investigation into the g-code files produced reveals that the filament start g-code is responsible for using the air filtration setting and sending the appropriate `M106 P3 S{during_print_exhaust_fan_speed_num[current_extruder]}` command to the printer. However, this command, even with the setting enabled, is never written to the final g-code file. By default, Bambu Lab's filament profiles wrap this command up in` {if activate_air_filtration[current_extruder] && support_air_filtration}` clause, which always evaluates to false. As it turns out, the printer's have the `support_air_filtration` flag set to `0` in the `fdm_machine_common.json` file. This change updates that value to `1` in the .json files for the X1, X1C, X1E, and P1S 0.4mm nozzles. This is then inherited to other nozzle sizes and user generated profiles. This is done by simply adding a line ` "support_air_filtration": "1",` to the .json to override the inherited setting. <!-- > Please provide a summary of the changes made in this PR. Include details such as: > * What issue does this PR address or fix? > * What new features or enhancements does this PR introduce? > * Are there any breaking changes or dependencies that need to be considered? --> Fixes #6066 # Screenshots/Recordings/Graphs N/A ## Tests Updated this flag in a custom user config for the printer than tried generating the code file with Air Filtration enabled and set to 70% The appropriate `M106 P3 S178 ` appears in the filament start gcode section of the file. <!-- > Please provide a summary of the changes made in this PR. Include details such as: > * What issue does this PR address or fix? > * What new features or enhancements does this PR introduce? > * Are there any breaking changes or dependencies that need to be considered? --> # Screenshots/Recordings/Graphs <!-- > Please attach relevant screenshots to showcase the UI changes. > Please attach images that can help explain the changes. --> ## Tests Updated this flag in a custom user config for the printer than tried generating the code file with Air Filtration enabled and set to 70% The appropriate `M106 P3 S178 ` appears in the filament start gcode section of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrcaSlicer includes exhaust fan settings for each filaments, however these settings do not take effect on Bambu Labs machines that include chamber temperature regulation fans.
Further investigation into the g-code files produced reveals that the filament start g-code is responsible for using the air filtration setting and sending the appropriate
M106 P3 S{during_print_exhaust_fan_speed_num[current_extruder]}command to the printer. However, this command, even with the setting enabled, is never written to the final g-code file.By default, Bambu Lab's filament profiles wrap this command up in
{if activate_air_filtration[current_extruder] && support_air_filtration}clause, which always evaluates to false. As it turns out, the printer's have thesupport_air_filtrationflag set to0in thefdm_machine_common.jsonfile.This change updates that value to
1in the .json files for the X1, X1C, X1E, and P1S 0.4mm nozzles. This is then inherited to other nozzle sizes and user generated profiles. This is done by simply adding a line"support_air_filtration": "1",to the .json to override the inherited setting.Fixes #6066
Screenshots/Recordings/Graphs
N/A
Tests
Updated this flag in a custom user config for the printer than tried generating the code file with Air Filtration enabled and set to 70%
The appropriate
M106 P3 S178appears in the filament start gcode section of the file.