Many Docker Building Fixes/Improvements #6552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the X11 server allows connections from the Docker container.
Removed fix for X11. Will add to DockerRun.sh
Added help comment to fix and ensure that your X11 server allows connections from the Docker container.
Add build on linux with docker section
remove low ram thing
AnotherSamWithADream
changed the title
SoftFever
reviewed
Sep 11, 2024
4 tasks
|
Any updates? It has been a month. :) |
SoftFever
previously approved these changes
Dec 24, 2024
SoftFever
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes made:
Added a comment in DockerRun.sh to help with "Authorization required, but no authorization protocol specified" error. The command,
xhost +local:dockerensures that the X11 server allows connections from the Docker container. Added docker build instructions to README.md. No breaking changes/dependencies that need to be considered. Updated Dockerfile to use the low-ram version of the "BuildLinux.sh" script because that is used everywhere else for Linux building.If the README changes aren't Orcaslicer style, please feel free to change them.
Screenshots/Recordings/Graphs
Before:
After:
It opened properly.
Tests
Tested on Ubuntu 24.04 LTS Noble aarch64/arm64.
I ran the program before and was getting the error "Authorization required, but no authorization protocol specified". After implementing the fix, the error went away. (I am not the best at testing).