Refactoring: Move implementation to header #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake uses separate build directory
Instead of using glob
release-sink-machinery takes too long.
|
The tests from the PR run fine on Linux with gcc or clang from Nix (don't remember which versions). The tests also fail on OSX with clang from Nix, so it seems to be an OSX specific problem. @the-real-blackh Do you have any input on this or suggestions on how to proceed? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ Code review, please don't merge ;) ]
Hi Stephen,
I finally started to work on some refactorings you've mentioned previously in various forum and issue threads. My plan was to move the implementation in sodium.cpp to sodium.h (this PR), introduce phantom template parameters for
light_ptr,stream_,cell_,node, making sure everything compiles and tests pass and then replacelight_ptrby actual values. Then work on the node garbage collector.Unfortunately I've run into a problem during step one: After moving
unsafe_new_streamtosodium.h(be24489), the tests fail because the stream's cleanup action doesn't seem to be run anymore. I've played around with a few things in order to understand the problem, but without success.When you find the time, could you maybe have a look in case you spot the problem right away? Any help appreciated!
Thanks and best,
Stefan