Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(albert): chunkage des données + recherche des informations #16

Merged
merged 9 commits into from
Nov 27, 2024

Conversation

maxgfr
Copy link
Member

@maxgfr maxgfr commented Nov 19, 2024

fix #17
fix #11
fix #6
fix #5

Copy link

socket-security bot commented Nov 19, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] network 0 88.6 kB baskaryan

🚮 Removed packages: pypi/[email protected], pypi/[email protected]

View full report↗︎

@maxgfr maxgfr requested a review from RealVidy November 19, 2024 08:28
Copy link
Contributor

@RealVidy RealVidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool d'avancer sur l'utilisation d'Albert !

J'ai laissé quelques commentaires pour refactor une fonction.

Le reste me montre qu'on pourrait sûrement voir ensemble comment setup ton IDE pour t'aider

* fix: chunk

* fix: finish

* fix: finish

* fix: finish

* fix: finish

* fix: done
@maxgfr maxgfr requested a review from RealVidy November 24, 2024 15:43
@maxgfr maxgfr changed the title feat(albert): utilisation de l'api au lieu du modèle en local feat(albert): chunkage des données + recherche des informations Nov 24, 2024
Copy link
Contributor

@RealVidy RealVidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas mal de petits changements à faire mais ça avance, c'est cool !

Ah et si possible, faire de plus petites PR la prochaine fois parce que là ça faisait beaucoup d'un coup, ça rend le boulot beaucoup plus difficile !

@maxgfr
Copy link
Member Author

maxgfr commented Nov 26, 2024

@RealVidy merci des retours ! une fois le merge effectué, on aura plus de visibilité pour segmenter plus

@maxgfr maxgfr merged commit d508a9f into main Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment