Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix sort of ids #3599

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix(frontend): fix sort of ids #3599

merged 1 commit into from
Dec 17, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review December 17, 2024 17:12
@pYassine pYassine merged commit 12ef250 into master Dec 17, 2024
14 checks passed
@pYassine pYassine deleted the feat-cerfa-dates branch December 17, 2024 17:20
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.55%. Comparing base (d1669aa) to head (fe7e076).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../components/usager-filter/usagersFilter.service.ts 71.42% 4 Missing ⚠️
...nage-usagers-page/manage-usagers-page.component.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3599      +/-   ##
==========================================
+ Coverage   66.51%   66.55%   +0.04%     
==========================================
  Files         910      910              
  Lines       14912    14913       +1     
  Branches     2067     2065       -2     
==========================================
+ Hits         9918     9925       +7     
+ Misses       4819     4813       -6     
  Partials      175      175              
Files with missing lines Coverage Δ
...ts/usager-filter/services/usagersSorter.service.ts 96.66% <100.00%> (+0.23%) ⬆️
...nage-usagers-page/manage-usagers-page.component.ts 24.19% <0.00%> (+0.28%) ⬆️
.../components/usager-filter/usagersFilter.service.ts 64.81% <71.42%> (+7.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1669aa...fe7e076. Read the comment docs.

@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.188.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants