Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rgga pas de alt sur image home #6382

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

feat: rgga pas de alt sur image home #6382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84042f8
feat: rgga pas de alt sur image home
Dec 20, 2024
b411bf1
chore: snap
Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/code-du-travail-frontend/src/modules/home/Search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const Search = () => {
<Image
priority={false}
src={IllustrationHomePrincipal}
alt="Illustration graphique du site montrant des personnes travaillant"
alt=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on peut pas juste supprimer la propriété ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si tu ne mets pas la propriété, elle ne va pas être mise dans le html. Il faut bien avoir un alt="" dans le code HTML. Cela me semble bon

width="577"
height="393"
/>
Expand Down
2 changes: 1 addition & 1 deletion ...ges/code-du-travail-frontend/src/modules/home/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ exports[`<Home /> should match snapshot 1`] = `
class="fr-col-md-5 fr-col-12"
>
<img
alt="Illustration graphique du site montrant des personnes travaillant"
alt=""
data-nimg="1"
decoding="async"
height="393"
Expand Down
Loading