Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSE-2738: Add ENTITIES AND TAGS column to non-ECS SnowAlert #70

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

sfc-gh-bkou
Copy link
Collaborator

@sfc-gh-bkou sfc-gh-bkou commented Jul 27, 2023

This has been tested on OZ. With the following steps:

  1. Cloned this module repo locally.
  2. Made the change, adding the ENTITIES AND TAGS columns locally
  3. Modified the OZ SnowAlert TF locally to point to the local repo
  4. Ran TF plan and apply to OZ
  5. Created a dummy alert rule view with data in the two columns.
  6. Validate that the snowalert.data.alerts view contains the dummy alert with data in the two columns.
    select * from snowalert.data.alerts where alert_time > dateadd(day, -1, current_timestamp) order by alert_time desc;
image

@sfc-gh-nlele
Copy link
Collaborator

lgtm!

@sfc-gh-bkou sfc-gh-bkou merged commit b04c209 into main Jul 28, 2023
@sfc-gh-bkou sfc-gh-bkou deleted the GSE-2738-add-new-columns branch July 28, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants